Closed Bug 340241 Opened 19 years ago Closed 19 years ago

Install updates button should be on the right

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.8 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ancestor.ak, Assigned: mwu)

References

Details

(Keywords: fixed1.8.1, polish)

Attachments

(1 file, 1 obsolete file)

Move buttons around, v2
3.41 KB, patch
robert.strong.bugs
: review+
darin.moz
: approval1.8.1+
Details | Diff | Splinter Review
When updates are available there's an [Install updates] button at the bottom of the Updates tab. It's placed on the left which I find slightly unintuitive. Probably because it's a confirmation button and you expect those to be on the right.
marking as an enhancement request.
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: 2.0 Branch → Trunk
Definitely not an enhancement as it's a problem with the existing state of things. Marking as blocking bug 329045 for investigation whether my concerns are valid.
Blocks: 329045
Severity: enhancement → minor
Version: Trunk → 2.0 Branch
(In reply to comment #2) > Definitely not an enhancement as it's a problem with the existing state of > things. Marking as blocking bug 329045 for investigation whether my concerns > are valid. > 329045 is already fixed.
beltzner a.k.a. all wise ue guru, want to make a call on this?
Yeah, Adam's right, it feels more natural in the "OK" position. Also, we should swap the position of the "Skip" and "Install Updates" button that Michael Wu put together in bug 307358.
I'll fix this.
Assignee: nobody → michael.wu
Whiteboard: [SWAG: 0.5d]
Attached patch Move buttons around (obsolete) — — Splinter Review
Attachment #226574 - Flags: review?(robert.bugzilla)
Okay, let's get it right this time..
Attachment #226574 - Attachment is obsolete: true
Attachment #226580 - Flags: review?(robert.bugzilla)
Attachment #226574 - Flags: review?(robert.bugzilla)
Comment on attachment 226580 [details] [diff] [review] Move buttons around, v2 Looks good and thanks Michael!
Attachment #226580 - Flags: review?(robert.bugzilla) → review+
Checked in to trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [SWAG: 0.5d]
Comment on attachment 226580 [details] [diff] [review] Move buttons around, v2 nominating for 1.8.1... safe ui polish fix
Attachment #226580 - Flags: approval1.8.1?
Keywords: polish
Comment on attachment 226580 [details] [diff] [review] Move buttons around, v2 a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)
Attachment #226580 - Flags: approval1.8.1? → approval1.8.1+
Checked in to MOZILLA_1_8_BRANCH for Firefox 2.0
Keywords: fixed1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: