340448 - The "Trim logs" admin command doesn't actually remove log files

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[cls]

There's a hardcoded reference to 'DogbertTip' instead of $tree.  In addition, the cgi is only removing the compressed logfiles.  The expanded html versions are not removed.

Comment 1

[cls]

Attachment: v1.0

Comment 2

[timeless]

Comment on attachment 224482 [details] [diff] [review]
v1.0

why not
opendir( D , $tree )

and
/\.(?:gz|brief\.html)$/

Comment 3

[cls]

(In reply to comment #2)
> (From update of attachment 224482 [details] [diff] [review] [edit])
> why not
> opendir( D , $tree )

Messah like quotes. :-D

> and
> /\.(?:gz|brief\.html)$/

Ok, I failed regex school.  Why '?:' ?

Comment 4

[cls]

Checked in with the suggested regex change which is supposed to not preserve (.gz|brief.html) as $1.

Checking in webtools/tinderbox/doadmin.cgi;
/cvsroot/mozilla/webtools/tinderbox/doadmin.cgi,v  <--  doadmin.cgi
new revision: 1.18; previous revision: 1.17
done