Closed
Bug 340477
Opened 19 years ago
Closed 19 years ago
add some styling (bold?) to the 'header' rows in the agenda-tree-view
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
Lightning 0.5
People
(Reporter: richard, Assigned: jminta)
Details
Attachments
(1 file)
|
3.48 KB,
patch
|
mattwillis
:
first-review+
mattwillis
:
second-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
as a follow up of 337848 (which was about showing only time instead of time+date in the agenda-tab-view).
There is not so much visual difference anymore between an event and the headers 'today', 'tomorrow' and 'soon'.
The idea is to add some special styling to those rows (maybe bold like TB).
Reproducible: Always
Expected Results:
An idea is to make those lines appear in bold just like the mailfolders tree in thunderbird.
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Updated•19 years ago
|
Target Milestone: --- → Lightning 0.3
| Assignee | ||
Comment 1•19 years ago
|
||
Patch adds properties to the headers in the agenda in order to make them bold. Other themes are, of course, welcome to style these headers as they wish.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #235472 -
Flags: second-review?(dmose)
Attachment #235472 -
Flags: first-review?(mattwillis)
Comment 2•19 years ago
|
||
Comment on attachment 235472 [details] [diff] [review]
use properties
> + var atomSvc = Components.classes["@mozilla.org/atom-service;1"]
Perhaps a comment here noting that to style the elements of a tree you need to use the atom service?
> +treechildren::-moz-tree-cell-text(agenda-header) {
And perhaps one here describing what "agenda-header" is? "Today, Tomorrow..."
r1=lilmatt
Attachment #235472 -
Flags: first-review?(mattwillis) → first-review+
Comment 3•19 years ago
|
||
dmose: This would be good to get in 0.3 if we could
Whiteboard: [needs review dmose]
Updated•19 years ago
|
Target Milestone: Lightning 0.3 → Lightning 0.5
Comment 4•19 years ago
|
||
Comment on attachment 235472 [details] [diff] [review]
use properties
r1/2=lilmatt (with dmose's blessing for me to do the r2)
Attachment #235472 -
Flags: second-review?(dmose) → second-review+
Updated•19 years ago
|
Whiteboard: [needs review dmose]
| Assignee | ||
Comment 5•19 years ago
|
||
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•