Closed Bug 340715 Opened 18 years ago Closed 18 years ago

Replace deprecated preventBubble() on MOZILLA_1_8_BRANCH

Categories

(Toolkit :: UI Widgets, defect)

1.8 Branch
x86
Windows 2000
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

()

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

Running Sunbird (build from MOZILLA_1_8_BRANCH) I got the following warning:

Warning: Event=command, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead. This seems to be caused by /toolkit/content/widgets/textbox.xml, line 280. 

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/textbox.xml&rev=1.21.4.6&mark=280#272
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #224748 - Flags: first-review?(mconnor)
Attachment #224748 - Flags: approval-branch-1.8.1?(mconnor)
While you're at it, why not do the same for all the few remaining instances of preventBubble?

http://lxr.mozilla.org/mozilla1.8/search?string=preventBubble
Attachment #224748 - Flags: first-review?(mconnor)
Attachment #224748 - Flags: first-review+
Attachment #224748 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #224748 - Flags: approval-branch-1.8.1+
I don't have cvs account so it would be nice if someone could check this in on branch for me.
Whiteboard: [checkin needed]
Landed on 1.8
Checking in toolkit/content/widgets/textbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/textbox.xml,v  <--  textbox.xml
new revision: 1.21.4.7; previous revision: 1.21.4.6
done
Keywords: fixed1.8.1
(In reply to comment #2)
Sure I can do. This patch fixes the remaining instances on mozilla1.8 branch. Do I need special approval from someone for changes in mozilla/minimo/ ?
Attachment #225782 - Flags: first-review?(mconnor)
Attachment #225782 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #224748 - Attachment description: replace preventBubble() with stopPropagation() → replace preventBubble() with stopPropagation() [checked in]
Attachment #225782 - Flags: first-review?(mconnor)
Attachment #225782 - Flags: first-review+
Attachment #225782 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #225782 - Flags: approval-branch-1.8.1+
Checked in attachment 225782 [details] [diff] [review] on the 1.8 branch.
mozilla/minimo/chrome/content/bindings/keylets.xml 	1.2.2.3
mozilla/minimo/chrome/content/preferences/preferences.js 	1.24.2.30
mozilla/toolkit/mozapps/extensions/content/extensions.xml 	1.17.2.6
mozilla/browser/components/feeds/content/options.xul 	1.1.2.6
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: