340715 - Replace deprecated preventBubble() on MOZILLA_1_8_BRANCH

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Stefan Sitter [:ssitter]]

Running Sunbird (build from MOZILLA_1_8_BRANCH) I got the following warning:

Warning: Event=command, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead. This seems to be caused by /toolkit/content/widgets/textbox.xml, line 280. 

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/textbox.xml&rev=1.21.4.6&mark=280#272

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: replace preventBubble() with stopPropagation() [checked in]

Comment 2

[Simon Bünzli]

While you're at it, why not do the same for all the few remaining instances of preventBubble?

http://lxr.mozilla.org/mozilla1.8/search?string=preventBubble

Comment 3

[Stefan Sitter [:ssitter]]

I don't have cvs account so it would be nice if someone could check this in on branch for me.

Comment 4

[Joey Minta]

Landed on 1.8
Checking in toolkit/content/widgets/textbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/textbox.xml,v  <--  textbox.xml
new revision: 1.21.4.7; previous revision: 1.21.4.6
done

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: fix remaining instances (mozilla1.8 branch)

(In reply to comment #2)
Sure I can do. This patch fixes the remaining instances on mozilla1.8 branch. Do I need special approval from someone for changes in mozilla/minimo/ ?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked in attachment 225782 [details] [diff] [review] on the 1.8 branch.
mozilla/minimo/chrome/content/bindings/keylets.xml 	1.2.2.3
mozilla/minimo/chrome/content/preferences/preferences.js 	1.24.2.30
mozilla/toolkit/mozapps/extensions/content/extensions.xml 	1.17.2.6
mozilla/browser/components/feeds/content/options.xul 	1.1.2.6