34074 - Pop3 - Needs to reselect the previously selected message after compacting the folder

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[jefft]

We need to reselect the folder and previous selected message after compacting 
the pop3 folder.

Comment 1

[David :Bienvenu]

reassign to Jeff - he knows the issues best.

Comment 2

[selmer (gone)]

Not beta2 stopper, marking M18.  Please add beta2 keyword if you disagree.

Comment 3

[scottputterman]

reassigning jefft's bugs to naving

Comment 4

[Navin Gupta]

*** Bug 69728 has been marked as a duplicate of this bug. ***

Comment 5

[Aleksey Nogin]

*** Bug 60487 has been marked as a duplicate of this bug. ***

Comment 6

[Navin Gupta]

*** Bug 92008 has been marked as a duplicate of this bug. ***

Comment 7

[Navin Gupta]

Attachment: proposed fix.

Comment 8

[Navin Gupta]

The fix is to save the first selected message before doing compact and 
then after the compact is over; if the folder is the open then reroot the
folder and restore the selection of the message. Note this is needed 
only for local folders so I have added mCompactCompletedAtom to local 
folder only and the notification is also only for local folder. 

Comment 9

[Navin Gupta]

Attachment: proposed fix, v2

Comment 10

[Navin Gupta]

The new patch makes it work for cases not covered before. david, please review.

Comment 11

[David :Bienvenu]

this seems needlessly complicated. Isn't there a way to avoid changing all the
GetDatabase calls? What I expected to see was js code checking if the currently
loaded folder was the one that was just compacted (in the notification handler)
and in that case, do the reroot. The code used to work this way - just checking
against the currently loaded folder.

Also, to get the first selected view index, couldn't you just call 
mOutlinerSelection->GetCurrentIndex(&currentIndex); ? That gives you what the
focused message is.

Comment 12

[Navin Gupta]

Well there are so many cases to handle

Compact this folder (one folder)
1) can / can't be compacted

these cases are handled in widgetglue.js

Compact All folders
1)currently selected folder can be compacted
2)currently selected folder can't be compacted

In this case there will be no notification from the backend because we 
are not doing anything to the currently selected folder

Auto-compact folders
In this case we initiate the compact all for local folders from backend. 
so I had to rely on the msgWindow.openFolder to tell us if this is the 
folder that is selected on the front end. 

Regarding the GetDatabase() calls we should not fire the folderLoaded event 
because it does a bunch of things like msgFolder.endFolderLoading() and 
other stuff in js that is not needed for compact.

For first selected msg index I will make the change. 

Comment 13

[David :Bienvenu]

I'm still confused - you can have 10 pop servers with local folders underneath
them, and imap filters can move messages to any of the folders under those pop
servers, can't they? Those are not servers of type none.

Re not firing folder loaded notification, I think it would be better to just
ignore the folder loaded notification, instead of not sending it.

Comment 14

[Navin Gupta]

Attachment: proposed fix, v3

Comment 15

[Navin Gupta]

So this version v3, is just as you noted in the comment above. 

Comment 16

[Navin Gupta]

Attachment: complete fix!!

Comment 17

[David :Bienvenu]

Ok, this looks very good, except for one thing - does it work in the case of
having a multiple selection? I.e., if you select one message, and then extend
the selection, do we still reload the correct message? I think the correct way
to actually figure out which message to reload is to find the view index of
nsMsgDBView::m_currentlyDisplayedMsgKey and not to try to deduce it from the
selection.

Comment 18

[Navin Gupta]

Attachment: revised patch

Comment 19

[Cavin Song]

r=cavin.

Comment 20

[Navin Gupta]

fix checked in. 

Comment 21

[Navin Gupta]

*** Bug 94288 has been marked as a duplicate of this bug. ***

Comment 22

[Sheela Ravindran]

verified after compaction the previous message is remembered and gets selected 
in the thread pane and loaded in the message pane.  I also checked having 
selected more than one message in the thread pane that after compaction it 
remembers to load the correct message that was loaded before compaction. 
Tested this with both compact this folder and compact all folders.  
Compaction initiated by the preference does not load the message pane but the 
thread pane is loaded with previous selection and is not blank like before. 
Checked with Navin and he said since this is initiated in the backend that this 
was the expected result.

builds:
2001-08-15-06 win98, linux
2001-08-17-04 mac