340866 - Anti-phishing only works on the last opened window (fails otherwise)

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[johngraciliano]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

The "Web Forgery" signal is only given inside the last Bon Echo 2.0a3 window open that was opened. It does not show in any former window. This has nothing to do with the "tabs".

Reproducible: Always

Steps to Reproduce:
1. Have a Firefox 2.0a3 (A.K.A. Bon Echo) open.
2. Open another window.
3. Within the original window (or any previous window)open the "Google Safe Browsing Test Page," i.e., http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html
Actual Results:  
No "Web Forgery" alert is given.

Expected Results:  
The "Web Forgery" alert should come up! As it does *only* within the last opened window.

Also to reproduce:
1. Open a Bon Echo window.
2. Open a second window.
3. Close the second window.
4. Got to the test page (within the first window).

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060529 BonEcho/2.0a3
Yep, that's true.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060608 Minefield/3.0a1
Tested latest branch nightly (sorry, pasted wrong UA string) and also present in trunk.

Comment 3

[Mike Connor [:mconnor]]

Tony, remember to assign the bug to yourself before accepting the bug (I know that Bugzilla UI is confusing here)

Comment 4

[Tony Chang (Google)]

Attachment: v1: use separate nav watcher per window

So the problem was that all windows were sharing a nsIDocNavStartProgressListener instance and the callback would only work with the last opened window.  Switching to separate instances fixes that.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 225292 [details] [diff] [review]
v1: use separate nav watcher per window

As I said earlier, blanket a=me for safe-browsing-only patches

Comment 6

[Tony Chang (Google)]

Fixed on branch and trunk.