341008 - incorrect PR_sscanf error checking in nsPermissionManager.cpp

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Per the documentation:
| Returns
| The number of items scanned and stored, or -1 if the conversion failed.

But the code checks for != 0.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 225061 [details] [diff] [review]
patch

r=mvl

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Committing to HEAD...
Checking in extensions/cookie/nsPermissionManager.cpp;
/cvsroot/mozilla/extensions/cookie/nsPermissionManager.cpp,v  <--  nsPermissionManager.cpp
new revision: 1.59; previous revision: 1.58
done

*** Committing to MOZILLA_1_8_BRANCH...
Checking in extensions/cookie/nsPermissionManager.cpp;
/cvsroot/mozilla/extensions/cookie/nsPermissionManager.cpp,v  <--  nsPermissionManager.cpp
new revision: 1.55.2.1; previous revision: 1.55
done