34106 - OS/2 Build enablement - Makefile.in changes

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Huynh Trinh]

With the acceptance of Bugzilla 31845, we are now submitting the 
addition changes to evntually enable OS2 build ( on Tinderbox someday)
Most of the changes are in the Makefile.in, autoconf.mk.in and 
configure.in.  I will be submitting them in small, manageables  
batches, for review. Hopefully I won't cause too many build breaks.
My thanks in advance to all the reviewers.

Comment 1

[Huynh Trinh]

Attachment: Batch01 - A dozen Makefile.in changes for SHORT_LIBNAME

Comment 2

[Huynh Trinh]

Attachment: Batch02 - Two very OS/2 specific Makefile.in

Comment 3

[Huynh Trinh]

Attachment: Batch02 - Two more very OS2 specific Makefile.in

Comment 4

[cls]

Patches have been checked in.

Comment 5

[Huynh Trinh]

Chris, Thank you for reviewing and accepting the previous 3 batches.
I will be submitting more as I goes thru all the makefile.in The next 
batch04 are still relatively straight forward.

Comment 6

[Huynh Trinh]

Attachment: Batch04 - Mostly changes for LIB_SUFFIX

Comment 7

[Huynh Trinh]

Attachment: Batch04-A - Resubmit using cvs -q diff -u options

Comment 8

[Huynh Trinh]

Chris, I will wait to see if the updated Batch04A facilitate 
processing at your end before I submit more.

Comment 9

[cls]

Ok, checked in patch 4a.  Sorry about the turn over time on this.

Comment 10

[Huynh Trinh]

Attachment: Batch05 - Changes to Configure.in

Comment 11

[Huynh Trinh]

Attachment: Batch06 - Changes to Autoconf.mk.in

Comment 12

[Huynh Trinh]

I was able to build OS2 successfully with the changes in Configure.in 
(Batch05)  and Autoconf.mk.in (Batch06) . Please review these 2 with 
extra attention. (ie I do not fully understand every aspect of these 2 
files). MOZ_JS_LIBS is new and will be used in subsequent batch of 
Makefile.in

Comment 13

[Huynh Trinh]

Attachment: Batch07 Makefile.in w MOZ_JS_LIBS, SHORT_LIBNAME, LIBSUFFIX

Comment 14

[Huynh Trinh]

Batch07 are more makekiles which requires SHORT_LIBNAMES.
- LIBSUFFIX replace .a
- MOZ_JS_LIBS replaces -lmozjs  and 
- MOZ_COMPONENT_LIBS  replaces -lxpxom and $(NSPR_LIBS)

Comment 15

[Huynh Trinh]

Attachment: Batch08 - More SHORT_LIBNAME

Comment 16

[cls]

Batches 05-08 have been checked in.

Comment 17

[Huynh Trinh]

Attachment: Batch09 - More LIB_SUFFIX and other macro subtitutions

Comment 18

[cls]

Batch 09 has been checked in.

Comment 19

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 20

[Huynh Trinh]

Attachment: Batch10 - More changes to Makefile.in for OS/2

Comment 21

[Huynh Trinh]

Attachment: Batch11 - Makesfile.in changes to enable OS2 build

Comment 22

[cls]

Batches 10 & 11 have been checked in.

Comment 23

[Huynh Trinh]

Attachment: Batch12 - More OS/2 makefile changes.

Comment 24

[Huynh Trinh]

Attachment: Batch13- OS2 changes to Makefile.in in "test" directory

Comment 25

[cls]

Batches 12 & 13 have been checked in.

Comment 26

[Huynh Trinh]

Attachment: Batch14 - Makefile.in for js/src and htmlparser/src

Comment 27

[Huynh Trinh]

Batch14
- fix a stray .: in htmlparser/src
- enable os2 build to for js/src

Comment 28

[Huynh Trinh]

Attachment: Batch15 - Rules.mk for OS2 VACPP

Comment 29

[Huynh Trinh]

Attachment: Batch16 - Makefile.in changes for OS2 VACPP

Comment 30

[cls]

Batch 14, 15, & 16 have been checked in.

Comment 31

[Huynh Trinh]

Thank you Chris for checking in Batch 14,15,16.
As you already know we are trying to replace -lmozjs with 
$(MOZ_JS_LIB) in the Makefile.in and we already submitted many of 
these. While they they are equivalent and would build fine in emx,
the OS2 build using VACPP with fail w/o the $(MOZ_JS_LIB).
I recently grep the Makefile again and found that there are some 25 
more makefile that need to be changed. Wonder if you have a magic wand 
or we have to submit these changes individually. Again thanks in 
advance for your help. Huynh.

Comment 32

[cls]

Sure, I can take care of that.

Comment 33

[Huynh Trinh]

Attachment: Batch17 - intl/locale/public/makefile.in export for OS2

Comment 34

[Huynh Trinh]

Attachment: Batch18 - modules/plugin/nglsrc compile nsPluginDirOS2.cpp

Comment 35

[Huynh Trinh]

Attachment: Batch19 - Makefile changes for VACPP

Comment 36

[Huynh Trinh]

Attachment: Batch20 - Misc Makefile.in changes for OS/2

Comment 37

[cls]

Batches 17-20 have been checked in.  I'm going on a 2 week vacation so you'll
need to speak with [e-mail] about any further batches (especially if you
want them in before the M16 branch).

Comment 38

[snizinsk]

That's enought fixes under this bug. Further OS/2 fixes will be brought forward 
under new bugs. Latest is now 40177. Thanks Chris for all your help!

Comment 39

[Colin Blake]

Batch 20 introduces an error. It defines EXTRA_DSO_LDOPTS as

$(MOZ_JS_LIBS) $(MOZ_COMPONENT_LIBS)

These two should be the other way around since MOZ_JS_LIBS doesn't define a 
library path (this was an earlier fix to the Makefile). 

But, this line shouldn't even be in there, since there's already a definition
of EXTRA_DSO_LDOPTS in the Makefile that is correct.

Just remove the first definition and everything will be good.

Colin.

Comment 40

[Colin Blake]

adding myself to the cc list

Comment 41

[cls]

Colin, I can't seem to find the problem that you are pointing out.  Which
Makefile.in is giving you problems?

Comment 42

[Colin Blake]

See 
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/js/src/liveconnect/Makefile.in

This already got fixed by someone else on May 25.

Comment 43

[cls]

Marking fixed per Colin's comment.