Protect against opening too many tabs at once when multiply selecting bookmarks

RESOLVED FIXED in Firefox 2 beta1

Status

()

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: moco, Assigned: moco)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta1
x86
Windows XP
fixed1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [SWAG: fixed on branch, trunk (places) covered by bug #340966])

Attachments

(1 attachment)

Protect against opening too many tabs at once when multiply selecting bookmarks

this bug tracks the branch version of a scenario that I've fixed on the trunk, see bug #340966 comment 5:

warn (under the proper circumstances) for the additional scenario that I forgot when I "fixed" bug #333734, which is selecting multiple items in the bookmarks UI and then doing open in tabs.
mconnor, I'm asking for blocking ff 2 because bug #333734 (where I should have fixed this scenario) was also blocking.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Whiteboard: [SWAG: 0.25 days, already fixed on the trunk, see bug #340966]

Updated

13 years ago
Flags: blocking-firefox2? → blocking-firefox2+
it turns out that on the 1.8 branch the bookmarks UI doesn't have this same functionality with bookmarks as places.  

if I multiple select bookmarks in bon echo and context menu, I get the simple "Open in New Tab" and not a "Open in Tabs" like I do with minefield.

so in order to fix this bug, I'd need to fix (or add, if it was never there) the "Open in Tabs if selecting multiple bookmarks" issue, see bug #341172

given bug #341172, I'm not so sure this blocks ff 2.0 anymore, so re-asking mconnor to see what he thinks.
Depends on: 341172
Flags: blocking-firefox2+ → blocking-firefox2?
Open in New Tab will act on all selected bookmarks (I tested that before I plussed this bug) and append them to the current tabset.  Definitely should still fix, though I'm not sure offhand how the context menu bits in the bookmark manager work.

Bug 341172 is about backporting a Places feature to Bookmarks, which isn't something we have time for, so we should find a way to just fix this.
Flags: blocking-firefox2? → blocking-firefox2+
mconnor, thanks for clarifying both this issue and #341172.  patching coming...
Created attachment 225232 [details] [diff] [review]
fix for the 1.8 branch

similar to what I did for the trunk on #340966, move the logic out to a function and then call it from the right places.
Comment on attachment 225232 [details] [diff] [review]
fix for the 1.8 branch

seeking r= from ben, who reviewed the other patches for bug #333734 (the original bug) and #340996 (which includes the version of this fix for the places on the trunk)
Attachment #225232 - Flags: review?(bugs)
Whiteboard: [SWAG: 0.25 days, already fixed on the trunk, see bug #340966] → [SWAG: fix in hand, awaiting reviews, already fixed on the trunk, see bug #340966]
No longer depends on: 341172
Comment on attachment 225232 [details] [diff] [review]
fix for the 1.8 branch

r=ben@mozilla.org

this looks much nicer. sorry for not suggesting this earlier.
Attachment #225232 - Flags: review?(bugs) → review+
Comment on attachment 225232 [details] [diff] [review]
fix for the 1.8 branch

seeking a= from mconnor for the 1.8 branch
Attachment #225232 - Flags: approval-branch-1.8.1?(mconnor)

Updated

13 years ago
Attachment #225232 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
fix landed on the branch
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [SWAG: fix in hand, awaiting reviews, already fixed on the trunk, see bug #340966] → [SWAG: fixed on branch, trunk (places) covered by bug #340966]
fyi, in order to keep trunk in sync with the 1.8 branch, I've landed this change on the trunk as well.
You need to log in before you can comment on or make changes to this bug.