341097 - Ctrl-W doesn't close window when tab bar is hidden in a script opened window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tomer Altman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060610 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060610 Minefield/3.0a1

Ctrl-W behavior should depend on tab-bar visibility rather than the option "Hide tab bar when only one web site is opened".
When the feature is unchecked, and a script opens a single window without a tab-bar, Ctrl-W blanks the page and adds a tab bar.
This is inconsistent with the idea that a window without a tab-bar is an untabbed window and should behave as an untabbed window, closing on ctrl-w.

Reproducible: Always

Steps to Reproduce:
1. Uncheck "Hide tab bar when only one web site is opened."
2. Go to the noted page (skip an advert if one appears).
3. Click on any of the thumbnails (an untabbed window appears).
4. Click ctrl-w.

Actual Results:  
The window is blanked and a tab bar appears.

Expected Results:  
The window should close.

Refer to bug #236721

Comment 1

[Simon Bünzli]

Attachment: treat toolbarless popups differently

We should continue to ignore browser.tabs.autoHide for toolbarless windows (as does the tabbrowser).

Comment 2

[Simon Bünzli]

OT: <label/>s for radio buttons are all nifty - but these are just too easy to hit. Sorry.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.479.2.149
mozilla/browser/base/content/browser.js 	1.643