341111 - NSS 3.11.1 libnssckbi.so built with Forte 6 update 2 doesn't have version strings.

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

I found that our NSS_3_11_1_RTM libnssckbi.so built with
Forte 6 update 2 on Solaris 9 SPARC (32-bit and 64-bit,
debug and optimized) doesn't have the 'what' and 'ident'
version strings.

Christophe, does your libnssckbi.so have the same problem?
Please try these commands:

  what libnssckbi.so | grep NSS
  ident libnssckbi.so | grep NSS

Comment 1

[Wan-Teh Chang]

I just built NSS_3_11_1_RTM on Solaris 9 SPARC with
Sun Studio 11.  libnssckbi.so in debug builds (32
and 64 bits) has the version string, but libnssckbi.so
in optimized builds (32 and 64 bits) doesn't have the
version string.

Comment 2

[Christophe Ravel]

We build on Sun Studio 11.

OPT/32:
$ what libnssckbi.so | grep NSS
$ ident libnssckbi.so | grep NSS
ident warning: no id keywords in libnssckbi.so

DBG/32:
$ what libnssckbi.so | grep NSS
$ ident libnssckbi.so | grep NSS

OPT/64:
$ what libnssckbi.so | grep NSS
$ ident libnssckbi.so | grep NSS
ident warning: no id keywords in libnssckbi.so

DBG/64:
$ what libnssckbi.so | grep NSS
$ ident libnssckbi.so | grep NSS

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

(In reply to comment #2)
> We build on Sun Studio 11.

So, according to your output, we get a warning on optimized builds,
and NO OUTPUT AT ALL on debug builds?  
The expression "not ready for prime time" comes to mind.

Comment 4

[Wan-Teh Chang]

Attachment: Proposed patch

We need to add a dummy reference to the __nss_builtins_rcsid
and __nss_builtins_sccsid strings.  Otherwise, the compiler
may optimize away these two version strings.  Please see
lib/ssl/sslcon.c and lib/ssl/sslver.c for an example of this
dummy reference.  (Search for "rcsid" in those two files.)

Comment 5

[Wan-Teh Chang]

Nelson, many NSS source files have RCS id strings but they
are ifdef'd with the DEBUG macro.  This is why the RCS 'ident'
command only warns about the lack of RCS id keywords in our
optimized builds.

Comment 6

[Christophe Ravel]

Comment on attachment 225290 [details] [diff] [review]
Proposed patch

I have to pass the review to somebody else (my knowledge in C is too far away now).
Alexei, do you want to take the review ?

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 225290 [details] [diff] [review]
Proposed patch

looks just like the way we do it in other shared libs.
r=nelson

Comment 8

[Wan-Teh Chang]

I checked in the proposed patch on the NSS trunk (3.12)
and NSS_3_11_BRANCH (3.11.2).

Comment 9

[Alexei Volkov]

Comment on attachment 225290 [details] [diff] [review]
Proposed patch

I didn't see this request until recently because review request was sent to [e-mail] account. The account is now deleted by bugzilla admin.