341114 - Coverity 517 SECU_ParseCommandLine leaks optstate

Status: RESOLVED FIXED

(NSS :: Tools, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

SECU_ParseCommandLine allocates an "optstate" and returns without destroying it.  
It should call PL_DestroyOptState(optstate) to destroy it.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

CID 517

Comment 2

[Alexei Volkov]

Attachment: fix v1

Deallocate optstate as well as optstring.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 226883 [details] [diff] [review]
fix v1

>     optstring[j] = '\0';
>     optstate = PL_CreateOptState(argc, argv, optstring);
>+    if (!optstate) {

optstring is leaked here.

>+        return SECFailure;
>+    }

Comment 4

[Alexei Volkov]

Attachment: free optstring if optstate allocation fails

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 227163 [details] [diff] [review]
free optstring if optstate allocation fails

Don't indent loser.  r=nelson
>+
>+  loser:
>+    PL_DestroyOptState(optstate);

Comment 6

[Alexei Volkov]

/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.74; previous revision: 1.73