341118 - Coverity 544 sec_pkcs12_decoder_verify_mac leaks allocated SECItem

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Coverity CID 544
sec_pkcs12_decoder_verify_mac() calls 

1317   SECItem *         params = NULL;

1348   params = PK11_CreatePBEParams(&p12dcx->macData.macSalt, p12dcx->pwitem,
1349                                 iteration);

which allocates a new SECItem, and a new params struct (to which the SECItem
points).  Then it calls 

1439 	    if (params) {
1440 		PK11_DestroyPBEParams(params);
1441 	    }

But surprisingly (!) PK11_DestroyPBEParams doesn't destroy (free) the SECItem
so the SECItem is leaked.  

I think the right fix is to change PK11_DestroyPBEParams to destroy its 
argument.  Bug 341117 calls for that.   But if that change isn't made,
then we need to stop the leak here.

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Marking as RESOLVED FIXED as the Bug 341117 should have fixed this.