341121 - Coverity 408 sec_PKCS7CreateEncryptObject leaks param & result

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

In sec_PKCS7CreateEncryptObject, the param allocated here is never freed.

251  	    } else {
252  		mechanism = PK11_AlgtagToMechanism(algtag);
253  		param = PK11_GenerateNewParam(mechanism,key);

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

CID 409.  The same function also leaks "result".  Allocated here:

207  	    result = (struct sec_pkcs7_cipher_object*)
208  		      PORT_ZAlloc (sizeof(struct sec_pkcs7_cipher_object));

leaked here

280  		if(rv != SECSuccess) {
281  		    return NULL;
282  		}

Comment 2

[Robert Relyea]

Attachment: Free result and param on the error path.

reviewers feel free to bounce the review to someone else if you are overloaded.
The patch is fairly straightforward.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 264175 [details] [diff] [review]
Free result and param on the error path.

looks right to me.

Comment 4

[Alexei Volkov]

Comment on attachment 264175 [details] [diff] [review]
Free result and param on the error path.

r=alexei.volkov

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Bob made this checkin today.

cvs commit: Examining .
Checking in p7local.c;
/cvsroot/mozilla/security/nss/lib/pkcs7/p7local.c,v  <--  p7local.c
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in p7local.c;
/cvsroot/mozilla/security/nss/lib/pkcs7/p7local.c,v  <--  p7local.c
new revision: 1.9; previous revision: 1.8
done

Checked in tip an branch.