341153 - Bookmark dragging highlight painted even if drag is to the same place

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Håkan Waara]

Drag a bookmark item a tiny bit to the side, and the blue drag highlight is drawn even if it's the item's starting position.

Comment 1

[froodian (Ian Leue)]

This is from the bookmarks bar (since this wasn't initially clear to me).  Personally, I'm not sure this is a bug.  The blue drag highlight demarkates where the bookmark button will sit when it "lands."  Even if you're landing in the same position, you're still landing.

Comment 2

[Samuel Sidler (old account; do not CC)]

I was just going to comment the same. I'm really not sure this is a bug.

Comment 3

[Håkan Waara]

I think it would make more sense if the drag would slide back, just like it does if you try to drop it on itself (which effectively this is, since you haven't moved it past any other bookmark).

Comment 4

[Chris Lawson (gone)]

But it *is* moving past another bookmark -- the mouse has left the original tracking rect for that bookmark button, and that's why it's drawing an insertion highlight.

There's not much that can be done about this without shrinking the tracking rects down and making "dead space" between bookmark items.

cl

Comment 5

[Håkan Waara]

Another to do is find all instances of trees/textfields and make them focusable.

Comment 6

[Håkan Waara]

Sorry, wrong bug.

Comment 7

[Stuart Morgan]

Attachment: fix

This has been annoying me recently.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 312776 [details] [diff] [review]
fix

sr=pink

did you try in a container with just 1 bookmark, or a container with just 2? i seem to recall those were good test cases from when i did dnd highlighting in the past.

Comment 9

[Stuart Morgan]

Yep, I tested a bunch of configurations, including 1 and 2 with combinations of folders and tabs.

Landed on trunk.