The default bug view has changed. See this FAQ.

Status

Camino Graveyard
Toolbars & Menus
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: acoolie, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

Details

Attachments

(1 attachment, 1 obsolete attachment)

8.39 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1

When loading a page, Camino shows things such as "Connecting to..." and others. These messages are helpful usually, but when trying to find out where a link goes (A feature normally implemented in Camino), it is quite hard to see. The instant a new connection is made, the href of the link goes away. Basically, I feel that link location should have priority over most other messages in the status bar.

Reproducible: Always

Steps to Reproduce:
1. Go to google.com (Or maybe a page that takes longer to load)
2. Quickly hover over a link

Actual Results:  
The link location quickly disappears.

Expected Results:  
The link location should stay in place until mouseout.
(Assignee)

Comment 1

11 years ago
Confirming.  This should be reasonable to do, since it looks like the link information is coming in through setStatus:OfType, whereas the various loading strings are coming from onLoadingStarted/onLoadingCompleted/onStatusChange:.

Taking.
Assignee: nobody → stuart.morgan
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 2

11 years ago
Created attachment 243442 [details] [diff] [review]
prioritize status strings

fix
Attachment #243442 - Flags: review?
(Assignee)

Comment 3

11 years ago
>+  eStatusLinkTarget    = 0, // like mouseover info

That should read 'link mouseover info'; I'll fix that on respin after it's reviewed.

Comment 4

11 years ago
Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

r=cl. Looks good.

>-  mTabTitle = [mLoadingStatusString retain];
>+  mTabTitle = [NSLocalizedString(@"TabLoading", @"") retain];

This doesn't require any string changes, does it?

cl
Attachment #243442 - Flags: review? → review+
(Assignee)

Comment 5

11 years ago
Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

Nope, same string we've always used.
Attachment #243442 - Flags: superreview?(mikepinkerton)
(Assignee)

Updated

11 years ago
Attachment #243442 - Flags: superreview?(mikepinkerton) → superreview?(joshmoz)
Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

sr=pink

in the .h, |mStatusStrings| should have a comment that it's a strong (owning) reference.
Attachment #243442 - Flags: superreview?(joshmoz) → superreview+
(Assignee)

Comment 7

11 years ago
Created attachment 244807 [details] [diff] [review]
with comments

As checked into trunk and MOZILLA_1_8_BRANCH
Attachment #243442 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.