341356 - Reload doesn't work

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060612 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060612 Minefield/3.0a1

Reload doesn't work.

Reproducible: Always

Steps to Reproduce:
1. Select Reload in the tool bar, or select View | Reload
Actual Results:  
Nothing happens

Expected Results:  
It reloads

It's non-Cairo, zip build. It has no extensions.

Comment 1

[Ryuichi KUBUKI]

This build works.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060612 Minefield/3.0a1 ID:2006061205 [cairo]


The broken one is an hourly build.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

*** Bug 341376 has been marked as a duplicate of this bug. ***

Comment 3

[aja+bugzilla]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060613 Minefield/3.0a1 ID:2006061305 [cairo]

is also broken

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I've created two test builds from today, one without bug 255942 and one without both bug 255942 and bug 176182. Could you test these and see if either of them works?

http://gavinsharp.com/ff/firefox-3.0a1-2006-06-13-07-no255942.zip
http://gavinsharp.com/ff/firefox-3.0a1-2006-06-13-07-no255942-no176182.zip

Comment 5

[aja+bugzilla]

Gavin's test build http://gavinsharp.com/ff/firefox-3.0a1-2006-06-13-07-no255942.zip
does not have the problem. Setting blocking 255942 per his request.

Also fixes tab drag/drop problem.

Comment 6

[Jure Repinc (JLP)]

Highlight All button in Find toolbar is also not working. And Alt+Left/Right arrow keyboard shortcuts also don't work anymore (on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060613 Minefield/3.0a1). Is this related to this bug or should I open a new one?

Comment 7

[aja+bugzilla]

(In reply to comment #6)
> Highlight All button in Find toolbar is also not working. And Alt+Left/Right
> arrow keyboard shortcuts also don't work anymore (on Mozilla/5.0 (X11; U; Linux
> i686; en-US; rv:1.9a1) Gecko/20060613 Minefield/3.0a1). Is this related to this
> bug or should I open a new one?
> 
WFM with (win) test build mentioned about in comment #5, so it's probably another 255942 regression. Some other are mentioned in trunk build forum thread. 

Comment 8

[Benjamin Smedberg]

Anything in the JS console?

Comment 9

[Jure Repinc (JLP)]

Nothing shows up in Error Console here.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix -w

This patch fixes this bug (and probably others) by always calling BindCompiledEventHandler. Before (in the non-shared case) this call was implicit in the call to CompileEventHandler, but since we always share now, we need to always call BindCompiledEventHandler, not only when we used to share.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 12

[Jure Repinc (JLP)]

I just checked it out with freshly compiled build (Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060614 Minefield/3.0a1) and I can verify that all bugs mentioned in this bug report.

Comment 13

[Jure Repinc (JLP)]

...are fixed.

Comment 14

[Ria Klaassen (not reading all bugmail)]

*** Bug 341512 has been marked as a duplicate of this bug. ***

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Same here, with build 2006-06-14-20 of SeaMonkey trunk on Windows XP.

Verified FIXED.