341360 - clearInterval broken (Smoothwheel hangs)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ria Klaassen (not reading all bugmail)]

- Install the extension I'll attach by unzipping it and putting it in the extensions folder
- Go to a page with a reason to scroll and scroll down and up again
- Result: Firefox hangs, does not react anymore

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-12+16%3A00&maxdate=2006-06-12+20%3A00

Maybe bug 255942 has caused this?
Bug 255942 does not seem very likely to me.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: Smoothwheel extension

Comment 2

[(not currently active) Ted Mielczarek]

It appears that window.clearInterval is not working, which is causing this hang.  I'll attach a testcase in a minute.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: testcase

You should see "broken" after 2 seconds if clearInterval fails to work.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Thank you! :)

Comment 5

[u52928]

Confirmed with Tinderbox Trunk of 13 June.

Windows XP-SP2

Comment 6

[Bob Clary [:bc] (inactive)]

regression range 2006-06-12-05 - 2006-06-13-05, maybe bug 176182 ?

Comment 7

[Ria Klaassen (not reading all bugmail)]

No, it is bug 255942, verified with Gavin's build. I meant in comment #0 that 243277 was not very likely, sorry, pasted wrongly. When you wide up the regression range a bit, also 255942 comes into view.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This was a silly (type|think)-o.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 225457 [details] [diff] [review]
Fix

r+sr=bzbarsky

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 11

[Andrew Schultz]

*** Bug 341526 has been marked as a duplicate of this bug. ***

Comment 12

[Bob Clary [:bc] (inactive)]

RCS file: /cvsroot/mozilla/js/tests/js1_5/Regress/regress-341360.js,v
done
Checking in regress-341360.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-341360.js,v  <--  regress-341360.js
initial revision: 1.1
done

Comment 13

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 windows/mac(ppc|tel)/linux 20060810