341711 - fix offset* properties to use unscrolled positions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is the other half of bug 334765.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

The offsetTop should be constant regardless of the scroll position, but it isn't.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fixes offset* regression.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

is this the right patch? it seems to be for something foreignObject-related.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 225835 [details] [diff] [review]
fix

oops, wrong patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: correct patch

this is the correct patch, sorry.

It's a very simple change :-)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 226257 [details] [diff] [review]
correct patch

Looks good

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.