341806 - [FIX]refresh header ignored when external helper app service invoked

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Marria Nazif]

The logic for handling refresh headers in nsExternalHelperAppService is broken.  To repro, send a refresh header and an unrecognized content type (which causes the external helper app service to be invoked).

In nsExternalHelperAppService.cpp, it seems that mOriginalChannel is always null, so probably there is something wrong with the call to GetDocumentChannel in RetargetLoadNotifications.

I'm not sure which component to put this bug under so feel free to move it if appropriate.

Comment 1

[Marria Nazif]

Attachment: cgi script displaying the issue

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well, the obvious reason this doesn't work is that we call RemoveRequest first.  This nulls out the mDocumentRequest in the docloader in this case, so mOriginalChannel comes back null.  That seems to be a regression from bug 233145.  biesi, do you happen to recall why you changed the order here?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

wow, that was almost 2.5 years ago. I don't think I had a good reason for this, I probably wanted to move it before the early return if getting the uri loader failed. I clearly didn't realize it had a side effect...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.