Closed Bug 341951 Opened 18 years ago Closed 18 years ago

Making a new folder in the bookmarks manager causes beep

Categories

(Camino Graveyard :: Bookmarks, defect)

Product:
Camino Graveyard
Component:
Bookmarks
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: froodian, Assigned: froodian)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Does what smorgan said
1.27 KB, patch
stuart.morgan+bugzilla
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
STR:

1. Cmd-B
2. From the plus button, choose "Add folder"

What happens: New folder sheet comes up, and NSBeep
What should happen: no beep
The beep is from trying to show a second sheet while the first is visible.  BWC's addBookmarkFolder: calls BookmarkViewController if the bookmark manager is visible, which in turn calls showDialogWithLocationsAndTitles:..., but then calls showDialogWithLocationsAndTitles: unconditionally after that.

If the showDialogWithLocationsAndTitles:... call is else-ified, the beep will go away.
And it works. :)
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #227865 - Flags: review?(stuart.morgan)
Comment on attachment 227865 [details] [diff] [review]
Does what smorgan said

r=me
Attachment #227865 - Flags: review?(stuart.morgan) → review+
Attachment #227865 - Flags: superreview?(mikepinkerton)
Comment on attachment 227865 [details] [diff] [review]
Does what smorgan said

sr=pink
Attachment #227865 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
Fixed trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Verified with latest trunk nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: