341954 - remove a few AssignWithConversion calls in gfx

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

the patch also moves a few variables to their first use.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

I made sure that only ASCII names are passed to this function.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in gfx/public/nsFont.h;
/cvsroot/mozilla/gfx/public/nsFont.h,v  <--  nsFont.h
new revision: 1.16; previous revision: 1.15
done
Checking in gfx/src/nsFont.cpp;
/cvsroot/mozilla/gfx/src/nsFont.cpp,v  <--  nsFont.cpp
new revision: 3.25; previous revision: 3.24
done
Checking in gfx/src/gtk/nsDeviceContextGTK.cpp;
/cvsroot/mozilla/gfx/src/gtk/nsDeviceContextGTK.cpp,v  <--  nsDeviceContextGTK.cpp
new revision: 1.138; previous revision: 1.137
done
Checking in gfx/src/photon/nsDeviceContextSpecPh.cpp;
/cvsroot/mozilla/gfx/src/photon/nsDeviceContextSpecPh.cpp,v  <--  nsDeviceContextSpecPh.cpp
new revision: 1.36; previous revision: 1.35
done

Comment 3

[steve.swanson]

The ASSERT added to the nsFont constructor fires when you load a MathML page.  Line 1194 of nsMathMLChar.cpp (in the InitGlobals() function) constructs a nsFont with nsnull name.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

heh. can you file a bug about that?

Comment 5

[steve.swanson]

Added bug 342533.  Will spend a few minutes looking for a clean fix.