Closed Bug 341965 Opened 18 years ago Closed 12 years ago

Hardcode MinGW builds to use --disable-accessibility

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mattwillis, Assigned: mattwillis)

References

Details

(Keywords: access)

Attachments

(1 file)

MinGW builds must use --disable-accessibility in their mozconfigs as the MinGW headers and libraries don't emulate accessibility.

We should add MinGW to the list of "OSes" that we disable accessibility for by default, rather than force folk to remember to turn it off by hand.
Attachment #226090 - Flags: review?(benjamin)
Attachment #226090 - Flags: approval-branch-1.8.1?(benjamin)
Comment on attachment 226090 [details] [diff] [review]
rev0 - adds mingw* to list of target OSes with accessibility disabled

When I'm building MSVC using the MSYS shell my target_os is mingw32, so this patch cannot be correct. I think you want a check for GNU_CC or something like that.
Attachment #226090 - Flags: review?(benjamin)
Attachment #226090 - Flags: review-
Attachment #226090 - Flags: approval-branch-1.8.1?(benjamin)
Is this still valid at all?
Keywords: access
Depends on: 815581
According to bug 815581 comment 20 it's WONTFIX. However, it's possible to build with accessibility on mingw.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: