Hardcode MinGW builds to use --disable-accessibility

RESOLVED WONTFIX

Status

Firefox Build System
General
--
minor
RESOLVED WONTFIX
12 years ago
4 months ago

People

(Reporter: Matthew (lilmatt) Willis, Assigned: Matthew (lilmatt) Willis)

Tracking

({access})

Trunk
x86
Windows XP
access

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
MinGW builds must use --disable-accessibility in their mozconfigs as the MinGW headers and libraries don't emulate accessibility.

We should add MinGW to the list of "OSes" that we disable accessibility for by default, rather than force folk to remember to turn it off by hand.
(Assignee)

Comment 1

12 years ago
Created attachment 226090 [details] [diff] [review]
rev0 - adds mingw* to list of target OSes with accessibility disabled
Attachment #226090 - Flags: review?(benjamin)
Attachment #226090 - Flags: approval-branch-1.8.1?(benjamin)

Comment 2

12 years ago
Comment on attachment 226090 [details] [diff] [review]
rev0 - adds mingw* to list of target OSes with accessibility disabled

When I'm building MSVC using the MSYS shell my target_os is mingw32, so this patch cannot be correct. I think you want a check for GNU_CC or something like that.
Attachment #226090 - Flags: review?(benjamin)
Attachment #226090 - Flags: review-
Attachment #226090 - Flags: approval-branch-1.8.1?(benjamin)

Comment 3

7 years ago
Is this still valid at all?
Keywords: access

Updated

6 years ago
Depends on: 815581

Comment 4

6 years ago
According to bug 815581 comment 20 it's WONTFIX. However, it's possible to build with accessibility on mingw.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.