341975 - "storage.sdb" (profile folder) should have a more explicit name

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Régis Caspar]

After the landing of bug 335101, there is a new file in Firefox profile folder named "storage.sdb". I think this file should have a more explicit name allowing users to know what its purpose is. Perhaps "search_data.sqlite" or something like that?

 -> Enhancement

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060618 Minefield/3.0a1 ID:2006061804 [cairo]

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This should just be a matter of using openDatabase with an nsIFile from the profile, instead of openSpecialDatabase.

Comment 2

[Régis Caspar]

Attachment: patch proposal

This patch proposal use "search_datas.sqlite" as filename.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 226113 [details] [diff] [review]
patch proposal

>+    var file = Cc["@mozilla.org/file/directory_service;1"]..
>+                  getService(Ci.nsIProperties).
>+                  get("ProfD", Ci.nsIFile);

Use the getDir() helper defined earlier in the file, and declare a NS_APP_USER_PROFILE_50_DIR constant near the other directory service keys at the top of the file. And don't double up the dots, and align the "getService" with "Cc", following the style of the rest of the file.

>+    file.append("search_datas.sqlite");

I'd prefer just "search.sqlite".

Comment 4

[Régis Caspar]

Attachment: patch proposal v2

Update following gavin's comments.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 226115 [details] [diff] [review]
patch proposal v2

>+    var file = getDir(NS_APP_USER_PROFILE_50_DIR);
>     var dbService = Cc["@mozilla.org/storage/service;1"].
>+                    getService(Ci.mozIStorageService);
>+    file.append("search.sqlite");

nit: move the |file.append| to right after the |var file|, no need to attach a new patch, I can fix on checkin.

Comment 6

[Régis Caspar]

(In reply to comment #5)
> nit: move the |file.append| to right after the |var file|, no need to attach a
> new patch, I can fix on checkin.
OK 

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.34

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.42