Closed Bug 342007 Opened 18 years ago Closed 18 years ago

Gray text in the search bar should be displayed in the chrome direction

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: fixed1.8.1, intl)

Attachments

(1 file)

patch
2.72 KB, patch
mconnor
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
We should always show the search engine name in the UI direction.

Easiest way to see the current beahavior is pressing enter in the search field when it's empty (after Switching its text direction).
Status: NEW → ASSIGNED
Summary: Reset search field text direction before setting its value to the active search engine name → Gray text in the search bar should be displayed in the chrome direction
Attached patch patch — — Splinter Review 

        Attachment #233650 -
        Flags: review?(mconnor)

    
  
Flags: blocking-firefox2?
Whiteboard: [needs review mconnor]

        Attachment #233650 -
        Flags: review?(mconnor) → review+

    
  

        Attachment #233650 -
        Flags: approval1.8.1?

    
  
Whiteboard: [needs review mconnor] → [needs approval]
Target Milestone: Firefox 2 beta1 → Firefox 2
Version: unspecified → 2.0 Branch

    
  
Whiteboard: [needs approval] → [needs approval][schrep-181approval pending]
Whiteboard: [needs approval][schrep-181approval pending] → [needs approval][schrep-181approval pending][checkin needed]

    
    

    
  
Comment on attachment 233650 [details] [diff] [review]
patch

a=schrep/beltnzer for drivers.

        Attachment #233650 -
        Flags: approval1.8.1? → approval1.8.1+

    
  
Flags: blocking-firefox2? → blocking-firefox2+

    
  
Whiteboard: [needs approval][schrep-181approval pending][checkin needed] → [checkin needed(1.8.1)]

    
    

    
  
1.8 branch:
mozilla/browser/base/content/browser.xul 1.268.2.61
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.37
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.48

leaving open for trunk checkin of browser.xul
Keywords: fixed1.8.1
Whiteboard: [checkin needed(1.8.1)]

    
    

    
  
browser.xul part landed on trunk:
mozilla/browser/base/content/browser.xul 1.320
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Bug 406095 is going to regress this; we should fix it for all emptyText textboxes.
Blocks: 406095

    
    

    
  
(In reply to comment #5)
> Bug 406095 is going to regress this; we should fix it for all emptyText
> textboxes.

Can you file a new bug for that?

    
  
Depends on: 416013

    
  
No longer blocks: 406095

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: