Gray text in the search bar should be displayed in the chrome direction

RESOLVED FIXED in Firefox 2

Status

()

Firefox
Search
--
minor
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

({fixed1.8.1, intl})

2.0 Branch
Firefox 2
fixed1.8.1, intl
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We should always show the search engine name in the UI direction.

Easiest way to see the current beahavior is pressing enter in the search field when it's empty (after Switching its text direction).
Status: NEW → ASSIGNED
Summary: Reset search field text direction before setting its value to the active search engine name → Gray text in the search bar should be displayed in the chrome direction
Flags: blocking-firefox2?
Whiteboard: [needs review mconnor]

Updated

12 years ago
Attachment #233650 - Flags: review?(mconnor) → review+
Whiteboard: [needs review mconnor] → [needs approval]
Target Milestone: Firefox 2 beta1 → Firefox 2
Version: unspecified → 2.0 Branch

Updated

12 years ago
Whiteboard: [needs approval] → [needs approval][schrep-181approval pending]
Whiteboard: [needs approval][schrep-181approval pending] → [needs approval][schrep-181approval pending][checkin needed]

Comment 2

12 years ago
Comment on attachment 233650 [details] [diff] [review]
patch

a=schrep/beltnzer for drivers.
Attachment #233650 - Flags: approval1.8.1? → approval1.8.1+

Updated

12 years ago
Flags: blocking-firefox2? → blocking-firefox2+

Updated

12 years ago
Whiteboard: [needs approval][schrep-181approval pending][checkin needed] → [checkin needed(1.8.1)]
1.8 branch:
mozilla/browser/base/content/browser.xul 1.268.2.61
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.37
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.48

leaving open for trunk checkin of browser.xul
Keywords: fixed1.8.1
Whiteboard: [checkin needed(1.8.1)]
browser.xul part landed on trunk:
mozilla/browser/base/content/browser.xul 1.320
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 5

11 years ago
Bug 406095 is going to regress this; we should fix it for all emptyText textboxes.
Blocks: 406095
(In reply to comment #5)
> Bug 406095 is going to regress this; we should fix it for all emptyText
> textboxes.

Can you file a new bug for that?

Updated

11 years ago
Depends on: 416013

Updated

11 years ago
No longer blocks: 406095
You need to log in before you can comment on or make changes to this bug.