Closed Bug 342010 Opened 18 years ago Closed 18 years ago

window.external.AddSearchProvider should support ftp URIs (IE compat)

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: asaf, Assigned: pamg.bugs)

References

(
URL
)

Details

(Keywords: fixed1.8.1, Whiteboard: [swag: 0.5d])

Attachments

(1 file)

Fixes issue
6.97 KB, patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
The code in validateSearchEngine (which is fine for legacy window.sidebar.addSearchEngine) rejects FTP urls. Looking at the documentation at MSDN, FTP urls should are legitimate.

See http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/addsearchprovider.asp
Flags: blocking-firefox2?
Should be trivial and harmless to add this.
Assignee: nobody → pamg.bugs
Flags: blocking-firefox2? → blocking-firefox2+
Any problem if window.sidebar.addSearchEngine is changed to allow ftp too?
(In reply to comment #2)
> Any problem if window.sidebar.addSearchEngine is changed to allow ftp too?

No, I think that should be fine.
Priority: -- → P2
Target Milestone: --- → Firefox 2 beta1
Attached patch Fixes issue — — Splinter Review 
Allows FTP for OpenSearch and Sherlock search description files and icons, no matter how they're provided: AddSearchProvider, addSearchEngine, or autodetected by <link>.
Attachment #226202 - Flags: review?(mconnor)
Comment on attachment 226202 [details] [diff] [review]
Fixes issue

thanks Pam!
Attachment #226202 - Flags: review?(mconnor)
Attachment #226202 - Flags: review+
Attachment #226202 - Flags: approval-branch-1.8.1+
Whiteboard: [swag: 0.5d]
fixed-1.8-branch, fixed-on-trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: