342010 - window.external.AddSearchProvider should support ftp URIs (IE compat)

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Asaf Romano (gone)]

The code in validateSearchEngine (which is fine for legacy window.sidebar.addSearchEngine) rejects FTP urls. Looking at the documentation at MSDN, FTP urls should are legitimate.

See http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/addsearchprovider.asp

Comment 1

[Mike Connor [:mconnor]]

Should be trivial and harmless to add this.

Comment 2

[Pam Greene]

Any problem if window.sidebar.addSearchEngine is changed to allow ftp too?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Any problem if window.sidebar.addSearchEngine is changed to allow ftp too?

No, I think that should be fine.

Comment 4

[Pam Greene]

Attachment: Fixes issue

Allows FTP for OpenSearch and Sherlock search description files and icons, no matter how they're provided: AddSearchProvider, addSearchEngine, or autodetected by <link>.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 226202 [details] [diff] [review]
Fixes issue

thanks Pam!

Comment 6

[Pam Greene]

fixed-1.8-branch, fixed-on-trunk