342053 - Quicksearch.pm defines $cgi outside routines

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Quicksearch.pm defines "my $cgi = Bugzilla->cgi;" outside routines. This makes "perl -cwT buglist.cgi" to fail, because buglist.cgi uses Quicksearch.pm. I saw this problem a few seconds before committing my patch about the removal of versioncache. ;)

We have to fix this before committing my patch about versioncache.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

move $cgi definition inside routines which use it.

Comment 2

[Frédéric Buclin]

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.7; previous revision: 1.6
done

Comment 3

[Max Kanat-Alexander]

FWIW, it's not possible for a call to "Bugzilla->cgi" to cause a problem at compile-time -- "Bugzilla->cgi" doesn't get resolved until runtime.

If this fixed the problem, the problem was something else strange.

Comment 4

[Frédéric Buclin]

I think that's because Bugzilla->cgi calls Param() which loads all params, including those in BugFields.pm, despite $dbh was not yet defined. Moving
$cgi = Bugzilla->cgi inside routines prevents to load all these params at compile time. That's my theory.

Comment 5

[Max Kanat-Alexander]

Ohhh, right, because it's a .pm file. I didn't even think of that.

Yeah, of course, .pm files should never define things outside of routines, except in very unusual circumstances.