Closed
Bug 342064
Opened 18 years ago
Closed 18 years ago
carbon icon decoder still built for cocoa widget builds
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: mark)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
928 bytes,
patch
|
jaas
:
review+
pavlov
:
superreview+
darin.moz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Doing a fresh Cocoa widget Firefox build, I noticed that we are still using the Carbon icon decoder after adding logic to the Makefile to select Carbon/Cocoa decooder based on widgets in use.
|
Assignee | |
Updated•18 years ago
|
Assignee: joshmoz → mark
|
|
Assignee | |
Comment 1•18 years ago
|
||
We shouldn't have .mm and .cpp files with different names. With this patch, we'll need to rename nsIconChannel.mm (Cocoa) to nsIconChannelCocoa.mm. I'm not renaming nsIconChannel.cpp to preserve cvs blame.
Attachment #226236 -
Flags: review?(joshmoz)
Attachment #226236 -
Flags: review?(joshmoz) → review+
Attachment #226236 -
Flags: approval1.8.1?
Attachment #226236 -
Flags: superreview?(pavlov)
|
||
Updated•18 years ago
|
Attachment #226236 -
Flags: superreview?(pavlov) → superreview+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked in on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 3•18 years ago
|
||
Comment on attachment 226236 [details] [diff] [review] Give the implementation files different names a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)
Attachment #226236 -
Flags: approval1.8.1? → approval1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•