Closed Bug 342081 Opened 18 years ago Closed 18 years ago

Default finding to case-insensitive

Categories

(Toolkit :: Find Toolbar, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: pkasting, Assigned: pkasting)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Given beng and beltzner's agreement in bug 340849 that case-insensitive searching is better for most people out there, this is a bug to change the default value for accessibility.typeaheadfind.casesensitive from -1 to 0.
Attached patch patch (obsolete) — Splinter Review
Here's the patch to do it.
Assignee: nobody → pkasting
Status: NEW → ASSIGNED
Attachment #226238 - Flags: superreview?(bugs)
Attachment #226238 - Flags: review?(bugs)
Attachment #226238 - Flags: approval-branch-1.8.1?(darin)
Can you add a comment explaining the pref values, please?
Attached patch patch v2Splinter Review
OK, this version adds a comment enumerating the possible values.
Attachment #226238 - Attachment is obsolete: true
Attachment #226241 - Flags: superreview?(bugs)
Attachment #226241 - Flags: review?(bugs)
Attachment #226241 - Flags: approval-branch-1.8.1?(darin)
Attachment #226238 - Flags: superreview?(bugs)
Attachment #226238 - Flags: review?(bugs)
Attachment #226238 - Flags: approval-branch-1.8.1?(darin)
Comment on attachment 226241 [details] [diff] [review]
patch v2

r+sr=ben@mozilla.org
Attachment #226241 - Flags: superreview?(bugs)
Attachment #226241 - Flags: superreview+
Attachment #226241 - Flags: review?(bugs)
Attachment #226241 - Flags: review+
Attachment #226241 - Flags: approval-branch-1.8.1?(darin) → approval-branch-1.8.1+
Blocks: 341716
Checked in on trunk:
modules/libpref/src/init/all.js 3.645

Checked in on MOZILLA_1_8_BRANCH for 1.8.1b1:
modules/libpref/src/init/all.js 3.585.2.37
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: