342108 - [FIX]Clicking link in Gmail launches extra blank tab

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

Link in tab launches first a blank untitled tab, then the tab with the link.

Regression between 1.9a1_2006061914 and 1.9a1_2006061917.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-19+13%3A00&maxdate=2006-06-19+22%3A00
Caused by Bug 337260?

Comment 1

[Boris Zbarsky [:bzbarsky]]

What are the steps to reproduce this starting with a vanilla trunk build with a brand-new account?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I meant brand-new profile.

Comment 3

[Ria Klaassen (not reading all bugmail)]

- Go to Gmail and login
- Open this message from bugzilla
- Click on the link to this bug

Comment 4

[Ria Klaassen (not reading all bugmail)]

Ah, sorry. I assumed wrongly that your bugmail was in Gmail. :)

Comment 5

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #0)
> Link in tab 
That was a typo. Meant "Link in Gmail".
Clicking every external link there launches an extra blank tab, also the adds on the right side.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ah, ok.  I can reproduce this.  I can also reproduce this after backing out bug 337260 locally...

Comment 7

[Ria Klaassen (not reading all bugmail)]

Thanks for the effort of backing out in any case. :)
That range is correct enough, but the link unnecessarily wide.
But it still contains too many bugs and too little possible culprits:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-19+13%3A00&maxdate=2006-06-19+18%3A00

Comment 8

[Boris Zbarsky [:bzbarsky]]

I'll try to poke at this some more later today, I guess.

Comment 9

[Martijn Wargers (dead)]

Backing out the patch from bug 337746 seems to fix the regression.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Mine, then.  And that makes sense; I'm seeing an attempt to set window.opener to null fail with a security exception.  Investigating now.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

There were actually three separate issues here:

1)  moz-safe-about protocol handler had the wrong contractid
2)  The check for about:blank in the security manager was using the innermost
    URI, which is a moz-safe-about URI.
3)  The moz-safe-about URIs didn't preserve the original path, which was needed
    to fix issue #2.

This patch makes gmail happy.

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 226374 [details] [diff] [review]
Fix

sr=jst

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed.