Closed Bug 342108 Opened 14 years ago Closed 14 years ago
[FIX]Clicking link in Gmail launches extra blank tab
Link in tab launches first a blank untitled tab, then the tab with the link. Regression between 1.9a1_2006061914 and 1.9a1_2006061917. http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-19+13%3A00&maxdate=2006-06-19+22%3A00 Caused by Bug 337260?
What are the steps to reproduce this starting with a vanilla trunk build with a brand-new account?
I meant brand-new profile.
- Go to Gmail and login - Open this message from bugzilla - Click on the link to this bug
Ah, sorry. I assumed wrongly that your bugmail was in Gmail. :)
(In reply to comment #0) > Link in tab That was a typo. Meant "Link in Gmail". Clicking every external link there launches an extra blank tab, also the adds on the right side.
Ah, ok. I can reproduce this. I can also reproduce this after backing out bug 337260 locally...
No longer blocks: 337260
Thanks for the effort of backing out in any case. :) That range is correct enough, but the link unnecessarily wide. But it still contains too many bugs and too little possible culprits: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-19+13%3A00&maxdate=2006-06-19+18%3A00
I'll try to poke at this some more later today, I guess.
Backing out the patch from bug 337746 seems to fix the regression.
Assignee: nobody → dveditz
Component: Tabbed Browser → Security
Product: Firefox → Core
QA Contact: tabbed.browser → toolkit
Mine, then. And that makes sense; I'm seeing an attempt to set window.opener to null fail with a security exception. Investigating now.
Assignee: dveditz → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
There were actually three separate issues here: 1) moz-safe-about protocol handler had the wrong contractid 2) The check for about:blank in the security manager was using the innermost URI, which is a moz-safe-about URI. 3) The moz-safe-about URIs didn't preserve the original path, which was needed to fix issue #2. This patch makes gmail happy.
Summary: Clicking link in Gmail launches extra blank tab → [FIX]Clicking link in Gmail launches extra blank tab
Comment on attachment 226374 [details] [diff] [review] Fix sr=jst
Attachment #226374 - Flags: superreview?(jst) → superreview+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.