342150 - Problem with dates in task (start time reset to 00:00 on save)

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Omar Bajraszewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3
Build Identifier: Gecko/20060619 Sunbird/0.3a2+

When I create a new task FOR TODAY and save it start time changes.

Reproducible: Always

Steps to Reproduce:
1.Create new task
2.enter a title
3.set today date and time and due date (any)
4.Save it

Actual Results:  
Start time changes to deafult (0:00)

Expected Results:  
Obvious

Gecko/20060619 Sunbird/0.3a2+

Comment 1

[Martin Schröder [:mschroeder]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060619 Sunbird/0.3a2+

Couldn't reproduce this problem. WFM

Comment 2

[Omar Bajraszewski]

Attachment: Creating new task

Look at the dates and times I entered

Comment 3

[Omar Bajraszewski]

Attachment: Result

What dates and time can you see?

Comment 4

[Omar Bajraszewski]

And I don't see any error messages in error console

Comment 5

[Martin Schröder [:mschroeder]]

We have different date formats:
Me: 20.06.2006
You: 2006-06-20

There were some bugs filed about problems with some date formats and the event/task dialog. Please, change your date format, try again and report back.

Comment 6

[Omar Bajraszewski]

Do you mean "Date text Format" in general settings?

Comment 7

[Omar Bajraszewski]

Switching between long a short format doesn't change anything. Problem still exists  

Comment 8

[Omar Bajraszewski]

Attachment: After changing date format

Doesn't help

Comment 9

[Omar Bajraszewski]

This bug is very annoying beacuse I have to edit the task to get proper dates.

Comment 10

[Omar Bajraszewski]

And when I edit start time the due date and time change too. For example in task 2  date was 20.06.2006 00:00; due 20.06.2006 23:55. I edit the wrong start time- enter 20:00 and in the same time due date changes to 2006-06-21 and due time changes to 19:55 (?). It shouldn't be like this

Comment 11

[Stefan Sitter [:ssitter]]

I can confirm if you add one important step that is only visible from screen shot: Create a task with start date set to today _and_ set alarm to fire 1 day before the task begins.

Comment 12

[Omar Bajraszewski]

Set all your settings like mine:

Date text format: short
below 60 minutes and 60 minutes
alarm all is  selected
alarm for events and tasks on
default time for events/tasks 1 day

Start day Monday
workweek mon-fri
Display from 8 AM until 5 PM

Default weeks: 4
Previous weeks  none

And now try to reproduce the problem

Comment 13

[Omar Bajraszewski]

this problem can be reproduce when default alarm setting for events/tasks is on

Comment 14

[Joey Minta]

Attachment: check isDate for matches

The tasks are coming in with an entryDate that has .isDate set to true.  This will .compare with anything on the same day and give 0.  That means we didn't actually set the value.

Comment 15

[Joey Minta]

Comment on attachment 227709 [details] [diff] [review]
check isDate for matches

-            (value.compare(item.dueDate) != 0))
+            (value.compare(item.dueDate) != 0) ||
+            (value.isDate != item.dueDate.isDate)
Missing a trailing paren there.
r=dmose

Comment 16

[Joey Minta]

patch checked in.

Comment 17

[Damian Szczepanik]

(In reply to comment #13)
> this problem can be reproduce when default alarm setting for events/tasks is on
and still can be reproduce when alarm settings for tasks is on

1. create new profile
2. goto tools -> options -> alarms
3. switch on alarm setting for tasks
3. double click on task pane to create new task
   -> default date is set to 0:00


please reopen it

confirmed with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+

Comment 18

[Omar Bajraszewski]

It works for me. Damian, when is time set to 0:00? Is it when you start creating a task or the time changes when you save the created task? The main problem was with changing start time after saving the task and now it's ok.

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

If this can be reproduced, we'd definitely want a fix for 0.3 for it.

Comment 20

[Damian Szczepanik]

Attachment: current result

this is what I mean as "default date is set to 0:00"

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060831 Calendar/0.3a2+

Comment 21

[Stefan Sitter [:ssitter]]

From reading previous posts (hope I got it right): 

The original problem - that the time set by user is reset to 00:00 on save - is fixed.

The new issue brought up by Damian is that the default time for new tasks is 00:00. Maybe that is something that can be improved e.g. by using the current time instead. But I don't think this is a problem that blocks 0.3.

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

Agreed.  That problem should be spun off into a new bug, and this bug marked as FIXED/VERIFIED

Comment 23

[Damian Szczepanik]

(In reply to comment #21)
> The original problem - that the time set by user is reset to 00:00 on save - is
> fixed.
Well, from my point of view this is the same bug, that's why I reopen it instead of create new issue - but right now I'm confused... this mean I was wrong?

> But I don't think this is a problem that blocks 0.3.
No, for sure not

Comment 24

[Stefan Sitter [:ssitter]]

(In reply to comment #23)
I'm closing this bug as the original problem has been fixed. 

Damian, please file a new bug about the default time for new tasks topic (if not already exist).

Comment 25

[Stefan Sitter [:ssitter]]

(In reply to comment #18)
> It works for me.
--> VERIFIED

Comment 26

[Damian Szczepanik]

Litmus testcase 2607 created

Comment 27

[Damian Szczepanik]

Litmus testcase 2614 created

Comment 28

[Omar Bajraszewski]

I can see this problem again with lightning 2007082803

Comment 29

[Stefan Sitter [:ssitter]]

(In reply to comment #28)

Which one of the different issues mentioned in this bug do you mean? Also ensure that you don't use a default event for tasks due to Bug 351084. Task times are saved correct for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/2007082801 Calendar/0.7pre.

Comment 30

[Omar Bajraszewski]

you're right :-)