Closed Bug 342150 Opened 18 years ago Closed 18 years ago
Problem with dates in task (start time reset to 00:00 on save)
93.84 KB, image/jpeg
83.79 KB, image/jpeg
90.91 KB, image/jpeg
1.45 KB, patch
|Details | Diff | Splinter Review|
9.11 KB, image/png
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3 Build Identifier: Gecko/20060619 Sunbird/0.3a2+ When I create a new task FOR TODAY and save it start time changes. Reproducible: Always Steps to Reproduce: 1.Create new task 2.enter a title 3.set today date and time and due date (any) 4.Save it Actual Results: Start time changes to deafult (0:00) Expected Results: Obvious Gecko/20060619 Sunbird/0.3a2+
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060619 Sunbird/0.3a2+ Couldn't reproduce this problem. WFM
Look at the dates and times I entered
What dates and time can you see?
And I don't see any error messages in error console
We have different date formats: Me: 20.06.2006 You: 2006-06-20 There were some bugs filed about problems with some date formats and the event/task dialog. Please, change your date format, try again and report back.
Do you mean "Date text Format" in general settings?
Switching between long a short format doesn't change anything. Problem still exists
This bug is very annoying beacuse I have to edit the task to get proper dates.
And when I edit start time the due date and time change too. For example in task 2 date was 20.06.2006 00:00; due 20.06.2006 23:55. I edit the wrong start time- enter 20:00 and in the same time due date changes to 2006-06-21 and due time changes to 19:55 (?). It shouldn't be like this
I can confirm if you add one important step that is only visible from screen shot: Create a task with start date set to today _and_ set alarm to fire 1 day before the task begins.
Set all your settings like mine: Date text format: short below 60 minutes and 60 minutes alarm all is selected alarm for events and tasks on default time for events/tasks 1 day Start day Monday workweek mon-fri Display from 8 AM until 5 PM Default weeks: 4 Previous weeks none And now try to reproduce the problem
this problem can be reproduce when default alarm setting for events/tasks is on
The tasks are coming in with an entryDate that has .isDate set to true. This will .compare with anything on the same day and give 0. That means we didn't actually set the value.
Assignee: nobody → jminta
Status: UNCONFIRMED → ASSIGNED
Attachment #227709 - Flags: first-review?(dmose)
Comment on attachment 227709 [details] [diff] [review] check isDate for matches - (value.compare(item.dueDate) != 0)) + (value.compare(item.dueDate) != 0) || + (value.isDate != item.dueDate.isDate) Missing a trailing paren there. r=dmose
Attachment #227709 - Flags: first-review?(dmose) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
(In reply to comment #13) > this problem can be reproduce when default alarm setting for events/tasks is on and still can be reproduce when alarm settings for tasks is on 1. create new profile 2. goto tools -> options -> alarms 3. switch on alarm setting for tasks 3. double click on task pane to create new task -> default date is set to 0:00 please reopen it confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+
It works for me. Damian, when is time set to 0:00? Is it when you start creating a task or the time changes when you save the created task? The main problem was with changing start time after saving the task and now it's ok.
If this can be reproduced, we'd definitely want a fix for 0.3 for it.
this is what I mean as "default date is set to 0:00" Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060831 Calendar/0.3a2+
From reading previous posts (hope I got it right): The original problem - that the time set by user is reset to 00:00 on save - is fixed. The new issue brought up by Damian is that the default time for new tasks is 00:00. Maybe that is something that can be improved e.g. by using the current time instead. But I don't think this is a problem that blocks 0.3.
Agreed. That problem should be spun off into a new bug, and this bug marked as FIXED/VERIFIED
(In reply to comment #21) > The original problem - that the time set by user is reset to 00:00 on save - is > fixed. Well, from my point of view this is the same bug, that's why I reopen it instead of create new issue - but right now I'm confused... this mean I was wrong? > But I don't think this is a problem that blocks 0.3. No, for sure not
(In reply to comment #23) I'm closing this bug as the original problem has been fixed. Damian, please file a new bug about the default time for new tasks topic (if not already exist).
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago → 18 years ago
Component: General → Tasks
OS: Windows XP → All
QA Contact: general → tasks
Hardware: PC → All
Resolution: --- → FIXED
Summary: problems with dates in task → Problem with dates in task (start time reset to 00:00 on save)
Version: unspecified → Trunk
(In reply to comment #18) > It works for me. --> VERIFIED
Status: RESOLVED → VERIFIED
Litmus testcase 2607 created
Whiteboard: [litmus testcase wanted]
Litmus testcase 2614 created
I can see this problem again with lightning 2007082803
(In reply to comment #28) Which one of the different issues mentioned in this bug do you mean? Also ensure that you don't use a default event for tasks due to Bug 351084. Task times are saved correct for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:184.108.40.206pre) Gecko/2007082801 Calendar/0.7pre.
you're right :-)
You need to log in before you can comment on or make changes to this bug.