342165 - Style issues in new preferences dialog (gray lines in winstripe theme)

Status: VERIFIED FIXED

(Calendar :: Preferences, defect)

Description

[Stefan Sitter [:ssitter]]

Style issues in new preferences dialog (gray lines in winstripe theme)

The new preferences dialog landed yesterday shows some style issues on Windows. For example there is a light gray line below various items.

This is caused by the following css rule in calendar/base/themes/winstripe/preferences/preferences.css:

    caption {
        border-bottom: 1px solid #ececec;
        padding: 4px 4px 0px 0px !important;
    }

If I search lxr for this style rule it is found in the following pinstripe files too:
  /browser/themes/pinstripe/browser/preferences/preferences.css
  /mail/themes/pinstripe/mail/preferences/preferences.css

But this rule is not found in the corresponding winstripe files for Firefox or Thunderbird. Removing the rule from Sunbird css file improves situation. But some other elements still look odd (in some way).

Todo: 
Check winstripe preferences.css file for style rules that belong to pinstripe theme only or that are missing from winstripe theme.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: remove pinstripe rules

Remove pinstripe rules from winstripe file. The rest (rules File Field Widget) looks ok / is identical to the rules found in Firefox or Thunderbird css file.

Comment 2

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

Thanks!

-> FIXED

Comment 3

[Stefan Sitter [:ssitter]]

*** Bug 342424 has been marked as a duplicate of this bug. ***

Comment 4

[Stefan Sitter [:ssitter]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060630 Sunbird/0.3a2+.