342187 - query params for advanced mode queries are in source code

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

In browser/components/safebrowsing/content/tr-fetcher.js, there are three query parameters in the source code.  These should be moved out of the code and into the browser.safebrowsing.provider.0.lookupURL pref.  Otherwise, other providers will get the query params automatically added.

Comment 1

[Tony Chang (Google)]

Attachment: v1: move args into params, clean up key management

Also clean up a memory leak in G_CryptoHasher.

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 227467 [details] [diff] [review]
v1: move args into params, clean up key management

This looks fine.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 227467 [details] [diff] [review]
v1: move args into params, clean up key management

sr=[e-mail]

Comment 4

[Tony Chang (Google)]

*** Bug 345090 has been marked as a duplicate of this bug. ***

Comment 5

[Tony Chang (Google)]

on trunk

This is needed for other data providers to work.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

We're gonna let this bake for another day before taking it, but it will block the release.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 227467 [details] [diff] [review]
v1: move args into params, clean up key management

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 once you have done so.

Comment 8

[Tony Chang (Google)]

on branch