342330 - nsStringStream::SetEOF not implemented yet called from nsStringStream::Read!

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

When using the XmlHttpRequest object in POST mode we've run into the following assertion:

###!!! ASSERTION: nsStringInputStream::SetEOF: 'NotYetImplemented', file
d:/Home/mozilla_1_8_branch/mozilla/xpcom/io/nsStringStream.cpp, line 302

It seems that SetEOF was never implemented and so the call to SetEOF from Read should be removed.

Here's the stack:

  xul.dll!nsStringInputStream::SetEOF()  Line 302 + 0x19        C++
  xul.dll!nsStringInputStream::Read(char * aBuf=0x02ca4950, unsigned int
aCount=4096, unsigned int * aReadCount=0x0184fde8)  Line 223   C++
  xul.dll!nsMultiplexInputStream::Read(char * aBuf=0x02ca4950, unsigned int
aCount=4096, unsigned int * _retval=0x0184fe18)  Line 197 + 0x23    C++
  xul.dll!nsBufferedInputStream::Fill()  Line 387 + 0x35        C++
  xul.dll!nsBufferedInputStream::ReadSegments(unsigned int (nsIInputStream *,
void *, const char *, unsigned int, unsigned int, unsigned int *)*
writer=0x101e2ad0, void * closure=0x02ca4208, unsigned int count=4096, unsigned
int * result=0x0184feb8)  Line 351 + 0x10      C++
  xul.dll!nsHttpTransaction::ReadSegments(nsAHttpSegmentReader *
reader=0x02ca71a0, unsigned int count=4096, unsigned int *
countRead=0x0184feb8)  Line 386 + 0x2b      C++
  xul.dll!nsHttpConnection::OnSocketWritable()  Line 559 + 0x1e C++
  xul.dll!nsHttpConnection::OnOutputStreamReady(nsIAsyncOutputStream *
out=0x02ca7470)  Line 770 + 0xb  C++
  xul.dll!nsSocketOutputStream::OnSocketReady(unsigned int condition=0)  Line
490       C++
  xul.dll!nsSocketTransport::OnSocketReady(PRFileDesc * fd=0x02ca7760, short
outFlags=2)  Line 1469     C++
  xul.dll!nsSocketTransportService::Run()  Line 585     C++
  xul.dll!nsThread::Main(void * arg=0x01019b98)  Line 118 + 0x1a        C++
  nspr4.dll!_PR_NativeRunThread(void * arg=0x01019cb0)  Line 436 + 0xd  C
  nspr4.dll!pr_root(void * arg=0x01019cb0)  Line 112 + 0xd      C
  msvcr71d.dll!_threadstartex(void * ptd=0x010205a8)  Line 241 + 0xd    C
  kernel32.dll!_BaseThreadStart@8()  + 0x37

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch v1.0 to remove SetEOF

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 226521 [details] [diff] [review]
Patch v1.0 to remove SetEOF

Can I check this in?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 226521 [details] [diff] [review]
Patch v1.0 to remove SetEOF

a=dbaron on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and
add the fixed1.8.1 keyword to this bug)

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on branch.