342341 - New preferences: New created categories are not stored and selectable

Status: VERIFIED FIXED

(Calendar :: Preferences, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060621 Sunbird/0.3a2+

New preferences: New created categories are not stored and selectable

Steps to reproduce:
1. Open Sunbirds preference dialog, select Categories tab
2. Create a new category -> new category is displayed
3. Leave dialog with OK
4. Create new event/task and select category created above -> not ok
5. Open Sunbirds preference dialog again, check categories -> not ok

Actual Results:
The new category is not selectable in event/task dialog. The new category is not shown preference dialog dialog when opening again.
  
Expected Results:
The new category is selectable and can be edited in preference dialog.

Additional Information:
Same error with linux build. No JavaScript errors are shown. Worked in old preferences dialog.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - removes some remnants of oldprefs

This fixed it for me.

Comment 2

[Joey Minta]

Comment on attachment 226643 [details] [diff] [review]
rev0 - removes some remnants of oldprefs

This doesn't feel right on first look.  According to XULPlanet, setting a preference's value actually sets the preference.  On non-instant apply platforms, this seems like it could cause problems, since our cancel handler only resets categories.  Or is the prefwindow smart enough to handle that cancel?

Comment 3

[Matthew (lilmatt) Willis]

*** Bug 342830 has been marked as a duplicate of this bug. ***

Comment 4

[Joey Minta]

Comment on attachment 226643 [details] [diff] [review]
rev0 - removes some remnants of oldprefs

minusing per previous comment and IRC discussion.

Comment 5

[Matthew (lilmatt) Willis]

(In reply to comment #2)
> Or is the prefwindow smart enough to handle that cancel?

It appears to be. I tested this on WinXP and the dialog acts as I expect. Changes are saved when clicking "OK" and not when clicking "Cancel"

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 226643 [details] [diff] [review]
rev0 - removes some remnants of oldprefs

rerequesting

Comment 7

[Joey Minta]

Comment on attachment 226643 [details] [diff] [review]
rev0 - removes some remnants of oldprefs

r=jminta based on the <preference>-does-not-watch-<textbox> explanation.

Comment 8

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED

Comment 9

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+

Comment 10

[Matthew (lilmatt) Willis]

-> VERIFIED

Comment 11

[Damian Szczepanik]

Litmus testcase 2627 created