Various modules assume functions are in global scope, when none are

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
User Accounts
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

2.23
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Bugzilla::User has a bunch of silly calls to &::Param, which is not a global function.

Bugzilla::Chart has some calls to &::ThrowUserError, which is also not a global function.
(Assignee)

Comment 1

12 years ago
Created attachment 226639 [details] [diff] [review]
v1

Pretty trivial fix.
Attachment #226639 - Flags: review?(LpSolit)

Comment 2

12 years ago
Comment on attachment 226639 [details] [diff] [review]
v1

process_bug.cgi also uses some constants as global:

1760:        unless ($control > &::CONTROLMAPNA)  {
1763:        if ($control == &::CONTROLMAPMANDATORY) {


Your patch looks good. r=LpSolit
Attachment #226639 - Flags: review?(LpSolit) → review+

Updated

12 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 3

12 years ago
Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.113; previous revision: 1.112
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
Checked in on the Erbix branch:

Checking in Bugzilla/Chart.pm;
/cvs/erbix-code/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/User.pm;
/cvs/erbix-code/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.2; previous revision: 1.1
done
You need to log in before you can comment on or make changes to this bug.