Closed Bug 342540 Opened 19 years ago Closed 19 years ago

Technorati search using Toolbar Search box fails

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: raisemachine, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: fixed1.8.1, Whiteboard: 181b1+)

Attachments

(2 files)

Screenshot of problem
120.07 KB, image/jpeg
Details
trivial patch
930 bytes, patch
mconnor
: review+
dbaron
: approval1.8.1+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060623 BonEcho/2.0a3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060623 BonEcho/2.0a3 Using the Technorati search engine (http://www.technorati.com) to perform a query from the search bar fails, but works when keyword(s) are entered directly on the http://www.technorati.com/search page. Reproducible: Always Steps to Reproduce: 1. Goto http://www.technorati.com/ 2. Open the search box menu 3. Choose 'Add Technorati Search' 4. Open the search box menu 5. Choose the new Technorati Search option 6. Focus the search box and search for something Actual Results: See the screenshot. Expected Results: The page should have returned my query results.
Attached image Screenshot of problem —
Attached patch trivial patch — — Splinter Review
This is mine, it's a regression from bug 341908.
Assignee: nobody → gavin.sharp
Status: UNCONFIRMED → ASSIGNED
Attachment #226803 - Flags: review?(mconnor)
Using the spec from the constructed URI object gives us the escaped string, which means that our later attempts to substitute parameters fails.
Severity: normal → major
Flags: blocking-firefox2?
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta1
Version: unspecified → 2.0 Branch
Should have mentioned earlier that this also fails using latest Trunk. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060623 Minefield/3.0a1 ID:2006062304 [cairo]
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [patch-r?]
Whiteboard: [patch-r?] → [patch-r?] 181b1+
Attachment #226803 - Attachment description: patch → trivial patch
Attachment #226803 - Flags: review?(mconnor) → review+
mozilla/browser/components/search/nsSearchService.js 1.45
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?] 181b1+ → 181b1+
Comment on attachment 226803 [details] [diff] [review] trivial patch This is a trivial fix with almost no chance of causing a regression (it's just reverting to how the code was before), I don't think it would benefit from trunk baking.
Attachment #226803 - Flags: approval1.8.1?
Whiteboard: 181b1+ → [a?] 181b1+
Attachment #226803 - Flags: approval1.8.1? → approval1.8.1+
mozilla/browser/components/search/nsSearchService.js 1.1.2.38
Keywords: fixed1.8.1
Whiteboard: [a?] 181b1+ → 181b1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: