342556 - New Preferences: Options dialog should be modal on Windows

Status: VERIFIED FIXED

(Calendar :: Preferences, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060623 Sunbird/0.3a2+

New Preferences: Options dialog should be modal on Windows

Steps to reproduce:
1. Open Sunbirds preference dialog
2. Select Sunbirds main window

Actual Results:
It is possible to select Sunbirds main window and it is possible to work in the main window while the preference dialog is still open.

Expected Results:
It is not possible to select the main window. The preference dialog must be closed using 'Ok' or 'Cancel' first.

I think the current behavior is OK for Linux systems. (Don't know about Mac OS X). But the default behavior on Windows is different. Firefox and Thunderbird already work that way, Sunbird should do the same.

Comment 1

[Matthew (lilmatt) Willis]

(In reply to comment #0)
> I think the current behavior is OK for Linux systems. (Don't know about Mac OS
> X). But the default behavior on Windows is different. Firefox and Thunderbird
> already work that way, Sunbird should do the same.

Mac OS X is not modal for Ff, Tb or Sb.

Patch forthcoming.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev0 - makes pref win modal depending on instantApply pref

I moved stuff inside the "else" so we don't get the prefs service, etc. etc. if the prefwindow is already open.

Comment 3

[Joey Minta]

Comment on attachment 226829 [details] [diff] [review]
rev0 - makes pref win modal depending on instantApply pref

+        // The prefwindow should only be modal on non-instant-apply platforms
+        var prefs = Components.classes["@mozilla.org/preferences-service;1"]
+                              .getService(Components.interfaces.nsIPrefService)
+                              .getBranch(null);
+
+        var instantApply = prefs.getBoolPref("browser.preferences.instantApply");
A good solution is to use nsIPrefBranch directly, instead of nsIPrefService. A better solution is to wait until I land my get-pref helpers and use them. r=jminta with that.

Comment 4

[Matthew (lilmatt) Willis]

patch (using getPrefSafe) checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED