342600 - Tools menu leaks Clear Private Data label

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060606 BonEcho/2.0a3

Steps to reproduce:
1. Install dbaron's Leak Monitor extension.
2. Tools > Add-ons (although which dialog you choose doesn't matter).
3. Close the Add-ons manager window.

Leak Monitor shows the following leak:
Leaks in window 0x214d270:

[+] [leaked object] (25b1d68) = [object Object]
 [ ] _defaultLabel = Clear Private Data

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Does it go away if you null out _defaultLabel in shutdown?
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.650&mark=1384#1357

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Oh, that wouldn't help, nevermind.

Comment 3

[Jesse Ruderman]

Nominating because this is really annoying when using the Leak Monitor extension.

Comment 4

[Hiro]

The opening and shutting of Preferences reproduces. 

Steps to reproduce:
1. Open Preferences
2. Close Preferences

Leaks in window 0x252e4f0:
[+] [leaked object] (2602ec0) = [object Object]
 [ ] _defaultLabel = Clear Private Data


Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060714 Minefield/3.0a1

Comment 5

[Kevin Henrikson]

Similar error with Help -> Check for Updates...

Leaks in window 0x24db138:
[+] [leaked object] (238c7b0) = [object Object]
 [ ] _defaultLabel = Clear Private Data

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0

So it seems just about any chrome window will trigger this leak.  Agree w/Jesse very annoying when using the plug-in to look for leaks.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 361041 has been marked as a duplicate of this bug. ***

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible patch

I bet this will fix it.  I still don't understand how I figured this out while debugging bug 393898, though.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 279066 [details] [diff] [review]
possible patch

This does in fact fix the leak with the download manager window; the addons window still seems to leak for other reasons.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I figured it out while debugging bug 393898 purely by accident.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 279066 [details] [diff] [review]
possible patch

r=mano

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in.

Comment 12

[u88484]

This was originally reported about the addons window and in comment 8, it was reported that it still leaks even with this patch that was checked in.  So shouldn't this still be open?  Or is that actually going to be fixed in bug 393898 as it seems dbaron may be suggesting in comment 9 here?

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I filed the issue with the addons window as bug 394514.