20.62 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email): review+
Mike Pinkerton (not reading bugmail): superreview+
57.37 KB, image/png
68.19 KB, image/png
34.84 KB, image/png
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060614 Camino/1.0+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060614 Camino/1.0+ As part of the checkin for bug 277278, we introduced a new "Advanced" button "tip". Currently it reads « In Advanced you can set the minimum font size or other font types for this region. » I propose we change it to « To set the minimum font size and other font types for this region, click Advanced... ». I'm not really crazy about the current version, in part because it uses the word "you", which I think is a little weird for a UI. Also, it says "or", though I don't get why - you can change Both the font size And the font types in the sheet. There's also a comma missing after Advanced. The new version would also go above the button, rather than below it. Reproducible: Always
We use "you" all throughout the prefpanes, so I don't think that's bad, but I do agree that the text could be less awkward. Perhaps just "Set the minimum font size and other font types for this region." This would keep parity with the tip text for webfeatures.prefpane's "Add sites that should be allowed to show pop-up windows to a list." The text should still be below the button though, since this is what we do with all our other tip texts. By the way, bug 277278 didn't introduce the tip, it just capitalized the word "Advanced."
ah, ok :). I see the reference in webfeatures, and then this sounds OK. I'm not exceptionally crazy about it just saying "Set...", but consistency works, and I don't like the idea of saying "click this" as well. and compromise is good, so I say your version works. p.s. as for you using "you" elsewhere, we only use it in Keychain access, and that wording needs to get changed too. Have it say «Edit your keychain items» (or maybe, Edit your keychain items with the Keychain Access app). And then make the "some websites won't let you save..." go on a separate line.
When this is done we should be sure to resize the window correctly (595px) and make "Page Colors" consistent with "Link appearance"
Created attachment 227914 [details] New Appearance.nib
Created attachment 227915 [details] Screenshot of the colors & links tab
One question: How should we do the px at the top of the prefpane? I just left it the way it was, but do we want it 20px from the top of the "this is inside the tabview" area, or 20px from the top of the tabs? (sorry for the bugspam)
Created attachment 227931 [details] Minor IRC tweaks This is more or less like the screenshots. Just a couple px here and there.
Created attachment 227933 [details] Sets min width/height
Created attachment 227936 [details] Not b0rken Sorry, that last nib was a dud (saved showing the wrong tab).
Created attachment 227938 [details] Makes dropdown menu longer Hi reed.
(In reply to comment #12) > Hi reed. Hi! How are you doing? :)
Comment on attachment 227938 [details] Makes dropdown menu longer r=me Hopefully this is the end of this party :-)
(In reply to comment #8) > One question: How should we do the px at the top of the prefpane? I just left > it the way it was, but do we want it 20px from the top of the "this is inside > the tabview" area, or 20px from the top of the tabs? (sorry for the bugspam) > actually, 10px from the bottom of the tabs. see http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/art/ct_tabpaneinset.gif and http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGControls/chapter_18_section_7.html#//apple_ref/doc/uid/TP30000359-DontLinkElementID_524
I was referring to the space between the tabs and the top of the window, not the tabs and the top of the inset, but thanks. It's dealt with (per IRC). :)
what are we fixing here? i'm so confused.
We're: - Changing "In Advanced you can set the minimum font size or other font types for this region." to "Set the minimum font size and other font types for this region." - Correcting margins and spacing to match all the other prefpanes' new standard - Making "Link appearance" "Link Appearance" to match "Page Colors" In other words, just cosmetic polish as part of the prefpane cleanup.
Created attachment 228247 [details] Screenshot of Colors & Links side I realized that the screenshots included are a few revisions out of date (even though there have only been minor changes since then). Uploading screenshots of the final versions for sr-ing pleasure. ;)
Created attachment 228248 [details] Screenshot of Links side
Created attachment 228249 [details] Screenshot of advanced sheet
Comment on attachment 227938 [details] Makes dropdown menu longer rs=pink
Fixed trunk and branch.