342651 - Want to be able to go to a DOM node in DOMI from venkman's console/watch/locals

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[:Gijs (he/him)]

As in description.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Patch, with a review request to people who are not sick, not too busy and who sort of maybe slightly care! :-D

I'm happy about this patch, except for two things:
* Is there really no better way to figure out if DOMI is there?
* When I do: /inspect document.createElement("p"); DOMI manages to open the right document, but it selects nothing and doesn't really seem to understand that I just created a note without putting it somewhere *in* the document, even though it definitely belongs to that document. Sigh. Fixing this will require DOMI hacking though, which is something I'm not feeling up to at 1.37am. "Maybe later"

That's about it, I think. :-)

Comment 2

[:Gijs (he/him)]

Attachment: Valid patch

I still don't understand how people manage late-night hacking and I don't (always).

This patch is actually valid JS.... I think. More so than the last, anyway.

Comment 3

[James Ross]

Comment on attachment 226950 [details] [diff] [review]
Valid patch

>Index: mozilla/extensions/venkman/resources/content/venkman-static.js

>+function isDOMThing(o)
>+{
>+    const nsIDOMNode     = Components.interfaces.nsIDOMNode;
>+    const nsIDOMDocument = Components.interfaces.nsIDOMDocument;
>+    return (isinstance(o, nsIDOMNode) || isinstance(o, nsIDOMDocument));

isinstance(o, nsIDOMDocument) implies isinstance(o, nsIDOMNode), so the former is not needed.


>Index: mozilla/extensions/venkman/resources/locale/en-US/venkman.properties

>+cmd.inspect.label  = &Inspect in DOM Inspector
>+cmd.inspect.params = [<expression>]
>+cmd.inspect.help   = Inspects (the result of) the expression as in DOM inspector.

"Inspects the result of <expression> in DOM Inspector." (note capital I)


r=silver with those fixed.

Comment 4

[:Gijs (he/him)]

Landed --> FIXED.