342670 - Leaking process information handle in nsDebugImpl.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Gardiner]

Compiling with /analyze switch gives the following warning:

c:\mozilla_src\mozilla\xpcom\base\nsdebugimpl.cpp(413) : warning C6335: Leaking process information handle 'pi.hThread'

MSDN documentation indicates that all handles in the PROCESS_INFORMATION structure need to be closed - http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/createprocess.asp

And this is illustrated in the example at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/createprocess.asp

So we should close the thread handle too.

-dave

Comment 1

[David Gardiner]

Attachment: Close pi.hThread handle

Comment 2

[:Gavin Sharp [email: [e-mail]]]

mozilla/xpcom/base/nsDebugImpl.cpp 	3.25
(I also butchered the commit message and accidentally force-committed new revisions of all the files in xpcom/base, oops)