Closed Bug 342670 Opened 18 years ago Closed 18 years ago

Leaking process information handle in nsDebugImpl.cpp

Categories

(Core :: XPCOM, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: David.R.Gardiner, Assigned: David.R.Gardiner)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

Compiling with /analyze switch gives the following warning:

c:\mozilla_src\mozilla\xpcom\base\nsdebugimpl.cpp(413) : warning C6335: Leaking process information handle 'pi.hThread'

MSDN documentation indicates that all handles in the PROCESS_INFORMATION structure need to be closed - http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/createprocess.asp

And this is illustrated in the example at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/createprocess.asp

So we should close the thread handle too.

-dave
Assignee: nobody → David.R.Gardiner
Status: NEW → ASSIGNED
Attachment #226970 - Flags: superreview?(shaver)
Attachment #226970 - Flags: review?(benjamin)
Attachment #226970 - Flags: review?(benjamin) → review+
Attachment #226970 - Flags: superreview?(darin.moz)
Attachment #226970 - Flags: superreview?(darin.moz) → superreview+
Whiteboard: [checkin needed]
mozilla/xpcom/base/nsDebugImpl.cpp 	3.25
(I also butchered the commit message and accidentally force-committed new revisions of all the files in xpcom/base, oops)
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: