Closed
Bug 342695
Opened 18 years ago
Closed 18 years ago
Improve SeaMonkey theme appearance on OS/2
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
Details
(Keywords: fixed-seamonkey1.1a)
Attachments
(3 files, 1 obsolete file)
12.29 KB,
image/png
|
Details | |
30.43 KB,
patch
|
mkaply
:
review+
neil
:
superreview+
iannbugzilla
:
approval-seamonkey1.1a+
|
Details | Diff | Splinter Review |
2.25 KB,
patch
|
mkaply
:
review+
iannbugzilla
:
approval-seamonkey1.1a+
|
Details | Diff | Splinter Review |
Similar to the work in bug 314843 and bug 336997 for toolkit apps I would like to improve the appearance of the Classic theme for SeaMonkey on OS/2, so that it looks more "native", especially regarding to menus and scrollbars. My guess is that this is really only relevant for the 1.8 branch but the patches should also go onto trunk.
Assignee | ||
Comment 1•18 years ago
|
||
Not ready for review yet, I first have to find out if a few weirdnesses were caused by this.
Assignee | ||
Comment 2•18 years ago
|
||
Attachment #227007 -
Attachment is obsolete: true
Assignee | ||
Comment 3•18 years ago
|
||
OK, this basically achieves what the respective Toolkit patch did after bug 336997. The GIF images are the same as in that bug, so I won't attach them again. I resorted a few lines about Windows in the jar.mn so that I could do it with two #ifdefs.
Attachment #230305 -
Flags: superreview?
Attachment #230305 -
Flags: review?(mozilla)
Assignee | ||
Updated•18 years ago
|
Attachment #230305 -
Flags: superreview? → superreview?(neil)
Comment 4•18 years ago
|
||
Comment on attachment 230305 [details] [diff] [review] Bring SeaMonkey OS/2 theme to save level as Firefox I suppose it will do given that nobody's written nsNativeThemeOS2.cpp yet ;-)
Attachment #230305 -
Flags: superreview?(neil) → superreview+
Comment 5•18 years ago
|
||
Comment on attachment 230305 [details] [diff] [review] Bring SeaMonkey OS/2 theme to save level as Firefox We can't really do an nsNativeThemeOS2 :)
Attachment #230305 -
Flags: review?(mozilla) → review+
Assignee | ||
Comment 6•18 years ago
|
||
Thanks for reviewing, patch now checked in on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 7•18 years ago
|
||
Comment on attachment 230305 [details] [diff] [review] Bring SeaMonkey OS/2 theme to save level as Firefox >+#ifdef XP_OS2 >+* skin/classic/global/menu.css (global/os2/menu.css) >+ skin/classic/global/menu/menu-check.gif (global/os2/menu/menu-check.gif) >+ skin/classic/global/menu/menu-arrow.gif (global/os2/menu/menu-arrow.gif) >+ skin/classic/global/toolbar.css (global/os2/toolbar.css) >+#else > * skin/classic/global/menu.css (global/win/menu.css) I didn't spot this until it merge conflicted with another patch I have in my tree, but I don't think the os2 menu.css strictly needs that leading * as it isn't preprocessed.
Assignee | ||
Comment 8•18 years ago
|
||
Right, thanks. Removed the "*" in front of os2/menu.css in CVS.
Assignee | ||
Comment 9•18 years ago
|
||
Users in the newsgroups found some minor issues that I think we should correct before putting this into branch: - if menu colors are different from grey the colored regions is only behind the words on the main menubar with grey gaps in between - when clicking the arrow on the right of the URL field the background of the dropdown is colored in the menu color - the same is true for the dropdown in the "Print" panel
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•18 years ago
|
||
This fixes the problems for me and also corrects the double autocomplete section in menu.css.
Attachment #232281 -
Flags: review?(mozilla)
Comment 11•18 years ago
|
||
Comment on attachment 232281 [details] [diff] [review] minor corrections r=mkaply
Attachment #232281 -
Flags: review?(mozilla) → review+
Assignee | ||
Comment 12•18 years ago
|
||
Additional patch checked in.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Attachment #232281 -
Flags: approval-seamonkey1.1a?
Attachment #230305 -
Flags: approval-seamonkey1.1a+
Attachment #232281 -
Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Assignee | ||
Comment 13•18 years ago
|
||
OK, checked the patches from attachment 230305 [details] [diff] [review] and attachment 232281 [details] [diff] [review] into 1.8 branch, including the typo mentioned in comment 7 and all new GIFs.
Keywords: fixed1.8.1
Updated•18 years ago
|
Keywords: fixed1.8.1 → fixed-seamonkey1.1a
You need to log in
before you can comment on or make changes to this bug.
Description
•