342766 - crash on xslt testcase

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brian Ryner (not reading)]

The testcase linked here crashes, because CSSLoader::Stop doesn't check that the hashtables are initialized before using them.  We could either add an IsInitialized check, or just initialize them up-front.  The latter seems simpler, what do you guys think?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

This is already fixed on trunk, so this is for branches only.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Aren't crashes traditionally marked Critical?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 227125 [details] [diff] [review]
Patch to fix

This never got flagged, but it was approved and landed for the 1.8.0 branch

Comment 4

[Adam Guthrie]

For what it's worth, the linked testcase does not crash 1.5.0.4 or the latest branch build for me.

Comment 5

[Jay Patel [:jay]]

v.fixed on 1.8.0 branch with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.5) Gecko/20060706 Firefox/1.5.0.5, no crash with testcase.  

But considering Adam's comment #4, if anyone was able to crash with an older build, please retest to see if the latest 1.5.0.5 builds works for you.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Did you mean to mark this fixed?

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yup

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://bugzilla.mozilla.org/attachment.cgi?id=226571 as the testcase on build Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070630 Minefield/3.0a6pre