342925 - browser.xul elements getting included in other XUL windows

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Tony Chang (Google)]

XUL elements that appear to be specific to browser.xul are getting included in other Chrome windows.  For example, if I open the JS console, then examine it with the DOM inspector, I see lots of browser.xul specific elements.  See attached screenshots.

This doesn't seem to happen on all XUL windows.  E.g., if I point the DOM inspector at itself, there are no extra elements.

Comment 1

[Tony Chang (Google)]

Attachment: linux

linux DOM inspector pointing at JS console

Comment 2

[Tony Chang (Google)]

Attachment: mac

Mac DOM inspector pointing at JS Console

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Some (all?) of this is probably due to the menu overlays that are there to make the mac menus work (see browser/base/content/baseMenuOverlay.xul).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sorry, I meant macBrowserOverlay.xul.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Indeed, a bunch of stuff is overlayed:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/jar.mn&rev=1.102&mark=5-8#4

Comment 6

[Asaf Romano (gone)]

Tony, this is all about the mac menubar (for non-browser windows, this also means the hidden window)

Comment 7

[Tony Chang (Google)]

It's also pulling in unrelated things, e.g., the safe browsing JS file is getting loaded as well.  Is there a way to control what gets pulled in and what doesnt? That is, maybe I shouldn't be loading the safe browsing code from global-scripts.inc.

Comment 8

[Asaf Romano (gone)]

I would load the safe browsing script files from browser.xul via <script/> elements (this isn't as slow as loadSubScript).