342930 - "You have asked to open [lots of] tabs at once" should read "You are about to open..."

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Grey Nicholson (they/them)]

Spin off from bug 333734 comment 44:

"You have asked to open" seems a bit too passive on the part of the user - they *told/ordered/demanded* that Firefox open the tabs. I think "You are about to open" is a better choice of words; for a start it matches "You are about to close".

Comment 1

[(not reading, please use [e-mail] instead)]

I agree with greg, the wording could be improved here:

we currently have:

You are about to close 26 open tabs.  Are you sure you want to continue?
[ ] Warn me when I attempt to close multiple tabs

You have asked to open 26 tabs at once.  This might slow down your system while the pages are loading.
[ ] Warn me when I attempt to open a lot of tabs at once

(Is it just me, or is the "open" in "close 26 open tabs" not necessary, because the only types of tabs you can close are open ones, right?)

How about changing these strings to be:

You are about to close 26 tabs.  Are you sure you want to continue?
[ ] Warn me when I attempt to close multiple tabs

You are about to open 26 tabs.  This might slow down your system while the pages are loading.  Are you sure you want to continue?
[ ] Warn me when I attempt to open a lot of tabs at once

beltzner, are you the resident wordsmith?

Comment 2

[Grey Nicholson (they/them)]

(In reply to comment #1)
> [ ] Warn me when I attempt to open a lot of tabs at once

How about:

[ ] Warn me when I attempt to open many tabs at once

...? - "many" is more succinct than "a lot of" and it sounds less clumsy and less casual.

(And very strictly, "a lot" and "at once" make a tautology, because if all the members of the lot weren't opened at once, they wouldn't form a single lot. (Yes, folks, "lot" means "group". (English is fun.)))

Comment 3

[Reed Loden [:reed]]

I think Seth meant to assign this to himself. Please correct me if I'm wrong.

Comment 4

[(not reading, please use [e-mail] instead)]

yes, thanks reed.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, but these are good points. I was never fully comfortable with where we ended up with these strings. Taking your and Greg's suggestions and merging them a bit (and adding some of my own mojo):

You are about to close 26 tabs.  Are you sure you want to continue?
[x] Warn me when I attempt to close multiple tabs

You are about to open 26 tabs.  This might slow down Firefox while the
pages are loading.  Are you sure you want to continue?
[x] Warn me when opening multiple tabs might slow down Firefox

And then in the pref panel:

[x] Warn me when closing multiple tabs
[x] Warn me when opening multiplle tabs might slow down Firefox

If we can't get &brandShortName to generate "Firefox", then we can use "my/your browser".

> beltzner, are you the resident wordsmith?

For the time being, at least. Reed Loden also gets my vote as a wordsmither to be listened to, fwiw. :)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

uh, without my typo, natch

Comment 7

[Grey Nicholson (they/them)]

(In reply to comment #5)
> If we can't get &brandShortName to generate "Firefox", then we can use "my/your
> browser".

There's no need to clarify which browser we're talking about, nor to make the user feel good by virtue of their ownership of a browser, nor to pretend we are the user and are talking to the computer... so I think "the browser" will do. :)

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of tab close prompt

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: scrfeen shot of tab open prompt

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of tab prefs

Comment 11

[(not reading, please use [e-mail] instead)]

> You are about to close 26 tabs.  Are you sure you want to continue?
>[x] Warn me when I attempt to close multiple tabs

fixed, see first screen shot.

>You are about to open 26 tabs.  This might slow down Firefox while the
>pages are loading.  Are you sure you want to continue?
>[x] Warn me when opening multiple tabs might slow down Firefox

fixed, see second screen shot.

>And then in the pref panel:
>
>[x] Warn me when closing multiple tabs
>[x] Warn me when opening multiple tabs might slow down Firefox

fixed, see third screen shot.

> If we can't get &brandShortName to generate "Firefox", then we can use >"my/your browser".

I was able to use brandShortName.

Patch coming. will seek r/a for firefox 2b2, so that these string changes can be part of 2.0

Comment 12

[(not reading, please use [e-mail] instead)]

[note, this last minute string change revealed a real issue, see bug #348183]

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: patch, but I need to rename some entities / properties

Comment 14

[(not reading, please use [e-mail] instead)]

in addition to change the entity names (for localizers, since the strings have changed), this would need to be ported to the trunk (for places).

Index: browser/components/places/content/controller.js
Index: browser/locales/en-US/chrome/browser/places/places.properties

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, entities / properties renamed

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 233321 [details] [diff] [review]
updated patch, entities / properties renamed

also seeking formal UI review for the new strings (suggested by beltzner)

Comment 17

[(not reading, please use [e-mail] instead)]

I'm hoping drivers accept this change, as the warn on open is new for ff2, and it would be nice to get the new strings right (and to update the warn on close strings to match.)

as for the trunk (and places), my plan is to back port this after my ff2b2 blockers are done.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 233321 [details] [diff] [review]
updated patch, entities / properties renamed

r=me

a=mconnor on behalf of drivers, for a mostly-strings change that needs to land ASAP

Comment 19

[(not reading, please use [e-mail] instead)]

fix landed on the branch.

I still need to back port this to the trunk.

Comment 20

[u60234]

Comment on attachment 233321 [details] [diff] [review]
updated patch, entities / properties renamed

>Index: browser/locales/en-US/chrome/browser/preferences/tabs.dtd
>===================================================================
>RCS file: /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/tabs.dtd,v
>retrieving revision 1.3.2.4
>diff -u -8 -p -r1.3.2.4 tabs.dtd
>--- browser/locales/en-US/chrome/browser/preferences/tabs.dtd	31 Jul 2006 09:20:47 -0000	1.3.2.4
>+++ browser/locales/en-US/chrome/browser/preferences/tabs.dtd	11 Aug 2006 23:33:22 -0000
>@@ -1,17 +1,20 @@
>+<!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd">
>+%brandDTD;
>+

brand.dtd is already included in tabs.xul, so no need to do it here.

Comment 21

[(not reading, please use [e-mail] instead)]

Attachment: patch, backport the fix to the trunk for both places and non-places

Comment 22

[(not reading, please use [e-mail] instead)]

note to dietrich:

the tabs.open* strings (as well as others string properties) are duplicated in these two files (which is why I fixed them twice)

http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties
http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/places/places.properties

This patch does not address the issue of moving them to a common place for both places and non-places.

Comment 23

[Dietrich Ayala (:dietrich)]

Comment on attachment 241130 [details] [diff] [review]
patch, backport the fix to the trunk for both places and non-places

looks ok. worked fine on both places and non-places.

Comment 24

[(not reading, please use [e-mail] instead)]

fixed on trunk as well.