"Warn me when" is not in the keyboard loop in General prefPane

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({access, fixed1.8.1, polish})

unspecified
Camino1.5
PowerPC
Mac OS X
access, fixed1.8.1, polish
Dependency tree / graph

Details

Attachments

(2 attachments, 2 obsolete attachments)

53.01 KB, image/png
Details
8.94 KB, patch
froodian (Ian Leue)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
If RSS detection ever lands, we can get this then; if not, by itself.
(Assignee)

Comment 1

11 years ago
When this happens:
"Load Home Page when" -> "Load home page when" (per bug 343098)
Syncing which bug fixes this :)
Blocks: 340412
No longer blocks: 316232
Blocks: 352048
(Assignee)

Comment 3

11 years ago
Created attachment 237795 [details]
Screenshot

Since bug 340412 will be in the Tabs prefpane, fixing this as a polish bug.
Assignee: nobody → stridey
Status: NEW → ASSIGNED
(Assignee)

Comment 4

11 years ago
Created attachment 237796 [details]
New Navigation.nib
Attachment #237796 - Flags: review?(alqahira)
(Assignee)

Comment 5

11 years ago
Created attachment 237798 [details]
New Navigation.nib

Fixes the problem the bug is for too.  :p
Attachment #237796 - Attachment is obsolete: true
Attachment #237798 - Flags: review?(alqahira)
Attachment #237796 - Flags: review?(alqahira)
Comment on attachment 237798 [details]
New Navigation.nib

You need to set the min width/height.

r=ardissone with that fixed
Attachment #237798 - Flags: review?(alqahira) → review-
(Assignee)

Comment 7

11 years ago
Created attachment 237900 [details] [diff] [review]
New Navigation.nib
Attachment #237798 - Attachment is obsolete: true
Attachment #237900 - Flags: review?(alqahira)
(Assignee)

Comment 8

11 years ago
Comment on attachment 237900 [details] [diff] [review]
New Navigation.nib

r=alqahira per previous comment.

Pink, this just fixes the tab chain in this prefpane, and plays the margins and polish game we did with all the other ones.
Attachment #237900 - Flags: superreview?(mikepinkerton)
Attachment #237900 - Flags: review?(alqahira)
Attachment #237900 - Flags: review+
Comment on attachment 237900 [details] [diff] [review]
New Navigation.nib

rs=pink
Attachment #237900 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 10

11 years ago
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.