Get a CSS error on displaying any SVG

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

({fixed1.8.0.7, fixed1.8.1})

Trunk
fixed1.8.0.7, fixed1.8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
CSS Error (resource://gre/res/svg.css :72.30): Unknown pseudo-class or
pseudo-element '-moz-svg-foreign-content'.  Ruleset ignored due to bad
selector.
(Assignee)

Comment 1

11 years ago
Created attachment 227395 [details] [diff] [review]
patch

The only callers to EnsureCatalogStyleSheet are svg\content\src\nsSVGElementFactory.cpp and xml\document\src\nsXMLContentSink.cpp in both cases they pass a fixed stylesheet.
Assignee: general → longsonr
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Attachment #227395 - Flags: review?(bzbarsky)
Comment on attachment 227395 [details] [diff] [review]
patch

Looks great.  r+sr=bzbarsky
Attachment #227395 - Flags: superreview+
Attachment #227395 - Flags: review?(bzbarsky)
Attachment #227395 - Flags: review+
(Assignee)

Comment 3

11 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 227395 [details] [diff] [review]
patch

We should take this on branches. This specific bug does not exist on branches (because they don't support foreignobject) but the risk is minimal and the patch belongs with the patch for bug 331883, which has landed on branches.
Attachment #227395 - Flags: approval1.8.1?
Attachment #227395 - Flags: approval1.8.0.6?
Blocks: 331883

Comment 5

11 years ago
Comment on attachment 227395 [details] [diff] [review]
patch

a=darin on behalf of drivers
Attachment #227395 - Flags: approval1.8.1? → approval1.8.1+
checked into 1.8.1
Keywords: fixed1.8.1
Created attachment 227606 [details] [diff] [review]
branch patch

This is the patch that should go into 1.8.0.6
Attachment #227606 - Flags: approval1.8.0.6?
Attachment #227395 - Flags: approval1.8.0.6?
Blocks: 346222
No longer blocks: 346222
Comment on attachment 227606 [details] [diff] [review]
branch patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #227606 - Flags: approval1.8.0.7? → approval1.8.0.7+
Fix checked into 1.8.0 branch
Keywords: fixed1.8.0.7
You need to log in before you can comment on or make changes to this bug.