342961 - Get a CSS error on displaying any SVG

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

CSS Error (resource://gre/res/svg.css :72.30): Unknown pseudo-class or
pseudo-element '-moz-svg-foreign-content'.  Ruleset ignored due to bad
selector.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

The only callers to EnsureCatalogStyleSheet are svg\content\src\nsSVGElementFactory.cpp and xml\document\src\nsXMLContentSink.cpp in both cases they pass a fixed stylesheet.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 227395 [details] [diff] [review]
patch

Looks great.  r+sr=bzbarsky

Comment 3

[Robert Longson [:longsonr]]

Checked in.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 227395 [details] [diff] [review]
patch

We should take this on branches. This specific bug does not exist on branches (because they don't support foreignobject) but the risk is minimal and the patch belongs with the patch for bug 331883, which has landed on branches.

Comment 5

[Darin Fisher]

Comment on attachment 227395 [details] [diff] [review]
patch

a=darin on behalf of drivers

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked into 1.8.1

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: branch patch

This is the patch that should go into 1.8.0.6

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 227606 [details] [diff] [review]
branch patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Daniel Veditz [:dveditz]]

Fix checked into 1.8.0 branch