Last Comment Bug 342995 - "Auto fill password in web forms" in Privacy prefpane isn't validated/invalidated on prefpane open
: "Auto fill password in web forms" in Privacy prefpane isn't validated/invalid...
Status: VERIFIED FIXED
: fixed1.8.1
Product: Camino Graveyard
Classification: Graveyard
Component: Preferences (show other bugs)
: unspecified
: PowerPC Mac OS X
-- minor (vote)
: Camino1.5
Assigned To: froodian (Ian Leue)
:
:
Mentors:
Depends on:
Blocks: 325880
  Show dependency treegraph
 
Reported: 2006-06-28 09:18 PDT by froodian (Ian Leue)
Modified: 2006-07-21 19:02 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch fixing enabled/checked dependancies (2.40 KB, patch)
2006-07-02 15:46 PDT, froodian (Ian Leue)
nick.kreeger: review+
stuart.morgan+bugzilla: review-
Details | Diff | Splinter Review
New Privacy.nib (17.97 KB, application/zip)
2006-07-02 15:47 PDT, froodian (Ian Leue)
alqahira: review+
Details
Screenshot of Privacy prefpane (79.73 KB, image/png)
2006-07-02 15:48 PDT, froodian (Ian Leue)
no flags Details
Screenshot of cookies sheet (99.08 KB, image/png)
2006-07-02 15:51 PDT, froodian (Ian Leue)
no flags Details
Screenshot of exceptions sheet (47.97 KB, image/png)
2006-07-02 15:51 PDT, froodian (Ian Leue)
no flags Details
New Privacy.nib (17.97 KB, application/zip)
2006-07-02 21:35 PDT, froodian (Ian Leue)
alqahira: review+
Details
Screenshot of Privacy prefpane (79.74 KB, image/png)
2006-07-02 21:35 PDT, froodian (Ian Leue)
no flags Details
Uses NSOnState and NSOffState everywhere (2.42 KB, patch)
2006-07-02 23:48 PDT, froodian (Ian Leue)
stuart.morgan+bugzilla: review+
mikepinkerton: superreview+
Details | Diff | Splinter Review
Fixes the min width/height, and goes back to 12 px (17.96 KB, application/zip)
2006-07-03 20:11 PDT, froodian (Ian Leue)
no flags Details
Final (hopefully) tweaks in the prefpane (17.96 KB, application/zip)
2006-07-03 23:32 PDT, froodian (Ian Leue)
alqahira: review+
Details
Screenshot of "final tweaks" Privacy prefpane (79.80 KB, image/png)
2006-07-03 23:33 PDT, froodian (Ian Leue)
no flags Details

Description User image froodian (Ian Leue) 2006-06-28 09:18:19 PDT
STR: 
1. Go to Prefs->Privacy
2. Disable Allow saving in the Keychain
3. Notice that "Auto fill password in web forms" gets disabled (should it get unchecked too if it's checked?)
4. Change prefpanes
5. Change back to Privacy

What happens: it's no longer disabled
What should happen: should stay disabled
Comment 1 User image froodian (Ian Leue) 2006-07-02 15:46:40 PDT
Created attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

This patch makes sure the checkbox has the right enabling when the prefpane loads, and ensures that it is unchecked if its parent is unchecked (since we don't autofill passwords if "Allow saving in the keychain" is off)
Comment 2 User image froodian (Ian Leue) 2006-07-02 15:47:47 PDT
Created attachment 227909 [details]
New Privacy.nib

This doesn't actually have anything to do with the patch, but I redid the nib while I was at it.  It had to be done at some point.
Comment 3 User image froodian (Ian Leue) 2006-07-02 15:48:18 PDT
Created attachment 227910 [details]
Screenshot of Privacy prefpane
Comment 4 User image froodian (Ian Leue) 2006-07-02 15:51:00 PDT
Created attachment 227911 [details]
Screenshot of cookies sheet

Note that the actions menu will report as being incorrectly placed in IB, since we draw the image on manually, and it's hard (impossible) to get the button borders correctly placed.  What I did was place the image on the prefpane, position it correctly, move the button to the same spot, then delete the image.  So it really is in the right place, even though it says it isn't. :)
Comment 5 User image froodian (Ian Leue) 2006-07-02 15:51:29 PDT
Created attachment 227912 [details]
Screenshot of exceptions sheet
Comment 6 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-02 21:27:31 PDT
Comment on attachment 227909 [details]
New Privacy.nib

r=me

Patch seems to work nicely, too.
Comment 7 User image froodian (Ian Leue) 2006-07-02 21:35:22 PDT
Created attachment 227922 [details]
New Privacy.nib

Same as the last one, but with the buttons 17 px apart.
Comment 8 User image froodian (Ian Leue) 2006-07-02 21:35:49 PDT
Created attachment 227923 [details]
Screenshot of Privacy prefpane
Comment 9 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-02 21:37:36 PDT
Comment on attachment 227922 [details]
New Privacy.nib

I think this looks better and conforms to one of our standard measurements for added niceness :)
Comment 10 User image Nick Kreeger 2006-07-02 21:55:21 PDT
Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

Code looks OK, i didn't test it tough. r=me
Comment 11 User image Stuart Morgan 2006-07-02 22:42:18 PDT
Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

>+    [mAutoFillPasswords setState:[self getBooleanPref:"chimera.keychain_passwords_autofill" withSuccess:NULL]];

This needs a ternary; setState: doesn't take a BOOL.
Comment 12 User image froodian (Ian Leue) 2006-07-02 23:48:38 PDT
Created attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere
Comment 13 User image froodian (Ian Leue) 2006-07-03 20:11:17 PDT
Created attachment 228003 [details]
Fixes the min width/height, and goes back to 12 px

12 pixels between buttons is standard cocoa, and there really isn't any reason to deviate from that, especially since all our nibs already have it in place (per IRC).
Comment 14 User image froodian (Ian Leue) 2006-07-03 23:32:56 PDT
Created attachment 228018 [details]
Final (hopefully) tweaks in the prefpane
Comment 15 User image froodian (Ian Leue) 2006-07-03 23:33:30 PDT
Created attachment 228019 [details]
Screenshot of "final tweaks" Privacy prefpane
Comment 16 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-04 00:01:00 PDT
Comment on attachment 228018 [details]
Final (hopefully) tweaks in the prefpane

r=me
Comment 17 User image Stuart Morgan 2006-07-11 21:12:35 PDT
Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

r=me.  Get the unrelated nib stuff out of here.
Comment 18 User image froodian (Ian Leue) 2006-07-11 21:43:46 PDT
Comment on attachment 227911 [details]
Screenshot of cookies sheet

All nib changes have been moved to bug 344328.  Sorry about the unrelated nib stuff.
Comment 19 User image Mike Pinkerton (not reading bugmail) 2006-07-12 05:40:43 PDT
Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

sr=pink
Comment 20 User image Nick Kreeger 2006-07-13 08:22:58 PDT
Cooking trunk and branch.

Note You need to log in before you can comment on or make changes to this bug.