The default bug view has changed. See this FAQ.

"Auto fill password in web forms" in Privacy prefpane isn't validated/invalidated on prefpane open

VERIFIED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
--
minor
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1

Details

Attachments

(1 attachment, 10 obsolete attachments)

2.42 KB, patch
Stuart Morgan
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
STR: 
1. Go to Prefs->Privacy
2. Disable Allow saving in the Keychain
3. Notice that "Auto fill password in web forms" gets disabled (should it get unchecked too if it's checked?)
4. Change prefpanes
5. Change back to Privacy

What happens: it's no longer disabled
What should happen: should stay disabled
(Assignee)

Comment 1

11 years ago
Created attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

This patch makes sure the checkbox has the right enabling when the prefpane loads, and ensures that it is unchecked if its parent is unchecked (since we don't autofill passwords if "Allow saving in the keychain" is off)
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #227908 - Flags: review?(nick.kreeger)
(Assignee)

Comment 2

11 years ago
Created attachment 227909 [details]
New Privacy.nib

This doesn't actually have anything to do with the patch, but I redid the nib while I was at it.  It had to be done at some point.
Attachment #227909 - Flags: review?(alqahira)
(Assignee)

Comment 3

11 years ago
Created attachment 227910 [details]
Screenshot of Privacy prefpane
(Assignee)

Comment 4

11 years ago
Created attachment 227911 [details]
Screenshot of cookies sheet

Note that the actions menu will report as being incorrectly placed in IB, since we draw the image on manually, and it's hard (impossible) to get the button borders correctly placed.  What I did was place the image on the prefpane, position it correctly, move the button to the same spot, then delete the image.  So it really is in the right place, even though it says it isn't. :)
(Assignee)

Comment 5

11 years ago
Created attachment 227912 [details]
Screenshot of exceptions sheet
Comment on attachment 227909 [details]
New Privacy.nib

r=me

Patch seems to work nicely, too.
Attachment #227909 - Flags: review?(alqahira) → review+
(Assignee)

Comment 7

11 years ago
Created attachment 227922 [details]
New Privacy.nib

Same as the last one, but with the buttons 17 px apart.
Attachment #227909 - Attachment is obsolete: true
Attachment #227922 - Flags: review?(alqahira)
(Assignee)

Comment 8

11 years ago
Created attachment 227923 [details]
Screenshot of Privacy prefpane
Attachment #227910 - Attachment is obsolete: true
Comment on attachment 227922 [details]
New Privacy.nib

I think this looks better and conforms to one of our standard measurements for added niceness :)
Attachment #227922 - Flags: review?(alqahira) → review+

Comment 10

11 years ago
Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

Code looks OK, i didn't test it tough. r=me
Attachment #227908 - Flags: review?(nick.kreeger) → review+
(Assignee)

Updated

11 years ago
Attachment #227908 - Flags: review?(stuart.morgan)

Comment 11

11 years ago
Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

>+    [mAutoFillPasswords setState:[self getBooleanPref:"chimera.keychain_passwords_autofill" withSuccess:NULL]];

This needs a ternary; setState: doesn't take a BOOL.
Attachment #227908 - Flags: review?(stuart.morgan) → review-
(Assignee)

Comment 12

11 years ago
Created attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere
Attachment #227908 - Attachment is obsolete: true
Attachment #227937 - Flags: review?(stuart.morgan)
(Assignee)

Comment 13

11 years ago
Created attachment 228003 [details]
Fixes the min width/height, and goes back to 12 px

12 pixels between buttons is standard cocoa, and there really isn't any reason to deviate from that, especially since all our nibs already have it in place (per IRC).
Attachment #227922 - Attachment is obsolete: true
Attachment #228003 - Flags: review?(alqahira)
(Assignee)

Comment 14

11 years ago
Created attachment 228018 [details]
Final (hopefully) tweaks in the prefpane
Attachment #228003 - Attachment is obsolete: true
Attachment #228018 - Flags: review?(alqahira)
Attachment #228003 - Flags: review?(alqahira)
(Assignee)

Comment 15

11 years ago
Created attachment 228019 [details]
Screenshot of "final tweaks" Privacy prefpane
Attachment #227923 - Attachment is obsolete: true
Comment on attachment 228018 [details]
Final (hopefully) tweaks in the prefpane

r=me
Attachment #228018 - Flags: review?(alqahira) → review+

Comment 17

11 years ago
Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

r=me.  Get the unrelated nib stuff out of here.
Attachment #227937 - Flags: superreview?
Attachment #227937 - Flags: review?(stuart.morgan)
Attachment #227937 - Flags: review+
(Assignee)

Comment 18

11 years ago
Comment on attachment 227911 [details]
Screenshot of cookies sheet

All nib changes have been moved to bug 344328.  Sorry about the unrelated nib stuff.
Attachment #227911 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Attachment #227912 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Attachment #228018 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Attachment #228019 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Attachment #227937 - Flags: superreview? → superreview?(mikepinkerton)
Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

sr=pink
Attachment #227937 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Updated

11 years ago
Whiteboard: [needs checkin]

Comment 20

11 years ago
Cooking trunk and branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
(Assignee)

Updated

11 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.