342995 - "Auto fill password in web forms" in Privacy prefpane isn't validated/invalidated on prefpane open

Status: VERIFIED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[froodian (Ian Leue)]

STR: 
1. Go to Prefs->Privacy
2. Disable Allow saving in the Keychain
3. Notice that "Auto fill password in web forms" gets disabled (should it get unchecked too if it's checked?)
4. Change prefpanes
5. Change back to Privacy

What happens: it's no longer disabled
What should happen: should stay disabled

Comment 1

[froodian (Ian Leue)]

Attachment: Patch fixing enabled/checked dependancies

This patch makes sure the checkbox has the right enabling when the prefpane loads, and ensures that it is unchecked if its parent is unchecked (since we don't autofill passwords if "Allow saving in the keychain" is off)

Comment 2

[froodian (Ian Leue)]

Attachment: New Privacy.nib

This doesn't actually have anything to do with the patch, but I redid the nib while I was at it.  It had to be done at some point.

Comment 3

[froodian (Ian Leue)]

Attachment: Screenshot of Privacy prefpane

Comment 4

[froodian (Ian Leue)]

Attachment: Screenshot of cookies sheet

Note that the actions menu will report as being incorrectly placed in IB, since we draw the image on manually, and it's hard (impossible) to get the button borders correctly placed.  What I did was place the image on the prefpane, position it correctly, move the button to the same spot, then delete the image.  So it really is in the right place, even though it says it isn't. :)

Comment 5

[froodian (Ian Leue)]

Attachment: Screenshot of exceptions sheet

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 227909 [details]
New Privacy.nib

r=me

Patch seems to work nicely, too.

Comment 7

[froodian (Ian Leue)]

Attachment: New Privacy.nib

Same as the last one, but with the buttons 17 px apart.

Comment 8

[froodian (Ian Leue)]

Attachment: Screenshot of Privacy prefpane

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 227922 [details]
New Privacy.nib

I think this looks better and conforms to one of our standard measurements for added niceness :)

Comment 10

[Nick Kreeger]

Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

Code looks OK, i didn't test it tough. r=me

Comment 11

[Stuart Morgan]

Comment on attachment 227908 [details] [diff] [review]
Patch fixing enabled/checked dependancies

>+    [mAutoFillPasswords setState:[self getBooleanPref:"chimera.keychain_passwords_autofill" withSuccess:NULL]];

This needs a ternary; setState: doesn't take a BOOL.

Comment 12

[froodian (Ian Leue)]

Attachment: Uses NSOnState and NSOffState everywhere

Comment 13

[froodian (Ian Leue)]

Attachment: Fixes the min width/height, and goes back to 12 px

12 pixels between buttons is standard cocoa, and there really isn't any reason to deviate from that, especially since all our nibs already have it in place (per IRC).

Comment 14

[froodian (Ian Leue)]

Attachment: Final (hopefully) tweaks in the prefpane

Comment 15

[froodian (Ian Leue)]

Attachment: Screenshot of "final tweaks" Privacy prefpane

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 228018 [details]
Final (hopefully) tweaks in the prefpane

r=me

Comment 17

[Stuart Morgan]

Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

r=me.  Get the unrelated nib stuff out of here.

Comment 18

[froodian (Ian Leue)]

Comment on attachment 227911 [details]
Screenshot of cookies sheet

All nib changes have been moved to bug 344328.  Sorry about the unrelated nib stuff.

Comment 19

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 227937 [details] [diff] [review]
Uses NSOnState and NSOffState everywhere

sr=pink

Comment 20

[Nick Kreeger]

Cooking trunk and branch.