Fix cosmetic issues with the Downloads prefPane

VERIFIED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({verified1.8.1})

unspecified
Camino1.5
PowerPC
Mac OS X
verified1.8.1

Details

Attachments

(2 attachments, 2 obsolete attachments)

8.11 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details
57.12 KB, image/png
Details
Bug 341701 required some nib changes for clarity (which didn't happen):

When we fix this, we should also reword the pref text to include the word
"successful" (or similar) to clarify, and change the "Upon successful download"
option text to be "When the download finishes" (or "is complete" or similar) to
eliminate redundancy.

--
We should also make the hint text position consistent with other hints and verify overall pane width and spacing, keyboard loop and first responder.
(Assignee)

Comment 1

11 years ago
Created attachment 227619 [details]
New Downloads.nib

I'm not really sure about the text here.  It now reads (when spoken) as "Remove successful downloads when the download completes," which doesn't have agreeing case. (dowloads / the download), but having a popup menu that just says "When they complete" seems bad too.  "Remove successfully downloaded items" is out because it's too long...  Thoughts?
Attachment #227619 - Flags: review?(alqahira)
(Assignee)

Comment 2

11 years ago
Created attachment 227620 [details]
Screenshot
(Assignee)

Updated

11 years ago
Assignee: nobody → stridey
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

11 years ago
Created attachment 227659 [details]
New Downloads.nib

Refined on IRC
Attachment #227619 - Attachment is obsolete: true
Attachment #227659 - Flags: review?(alqahira)
Attachment #227619 - Flags: review?(alqahira)
(Assignee)

Comment 4

11 years ago
Created attachment 227660 [details]
Screenshot
Attachment #227620 - Attachment is obsolete: true
Attachment #227659 - Flags: review?(alqahira) → review+
Attachment #227659 - Flags: superreview?(mikepinkerton)

Comment 5

11 years ago
I think "passed off" should be "passed on." In U.S. English, "pass off" means to offer up an imitation as something genuine (see http://dictionary.reference.com/browse/pass)

Comment 6

11 years ago
"Passed off as" and "passed off to" are two completely different phrases.

Our current terminology is perfectly fine.

cl
(Assignee)

Comment 7

11 years ago
This new nib:

- Changes "Remove download list items: \ Upon successful download" to "Remove successful downloads: \ Upon completion"
- Unindents the hint text at the bottom of the pane
Comment on attachment 227659 [details]
New Downloads.nib

sr=pink
Attachment #227659 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Updated

11 years ago
Whiteboard: [needs checkin]

Comment 9

11 years ago
Fixed trunk and branch
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: polish → fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
(Assignee)

Updated

11 years ago
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.