Bug 341701 required some nib changes for clarity (which didn't happen): When we fix this, we should also reword the pref text to include the word "successful" (or similar) to clarify, and change the "Upon successful download" option text to be "When the download finishes" (or "is complete" or similar) to eliminate redundancy. -- We should also make the hint text position consistent with other hints and verify overall pane width and spacing, keyboard loop and first responder.
I'm not really sure about the text here. It now reads (when spoken) as "Remove successful downloads when the download completes," which doesn't have agreeing case. (dowloads / the download), but having a popup menu that just says "When they complete" seems bad too. "Remove successfully downloaded items" is out because it's too long... Thoughts?
Refined on IRC
13 years ago
Attachment #227659 - Flags: review?(alqahira) → review+
13 years ago
Attachment #227659 - Flags: superreview?(mikepinkerton)
I think "passed off" should be "passed on." In U.S. English, "pass off" means to offer up an imitation as something genuine (see http://dictionary.reference.com/browse/pass)
"Passed off as" and "passed off to" are two completely different phrases. Our current terminology is perfectly fine. cl
This new nib: - Changes "Remove download list items: \ Upon successful download" to "Remove successful downloads: \ Upon completion" - Unindents the hint text at the bottom of the pane
Comment on attachment 227659 [details] New Downloads.nib sr=pink
Attachment #227659 - Flags: superreview?(mikepinkerton) → superreview+
Fixed trunk and branch
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: polish → fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.